Closed Bug 1491066 Opened 6 years ago Closed 6 years ago

dom.ua_widget.enabled breaks ::cue

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: emilio, Assigned: timdream)

References

Details

Attachments

(1 obsolete file)

Assignee: nobody → timdream
Status: NEW → ASSIGNED
There is already a patch in bug 1484048. https://phabricator.services.mozilla.com/D3667 . I can land that patch w/ from this bug.
With UA Widget, the videocontrols container is created lazily. It won't be a problem for WebVTT.processCues() in vtt.jsm, so TextTrackManager::UpdateCueDisplay() should not early return there, but pass nullptr to it.
Comment on attachment 9008914 [details] Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu Alastor Wu [:alwu] has approved the revision.
Attachment #9008914 - Flags: review+
Pushed by tchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b88bbab404c6 Allow TextTrackManager to pass cue without videocontrols r=alwu
I have to say, the whole thing is a bit flicky for me, sometimes it shows up, sometimes it doesn't and it only shows up with a reload. But that's a separate bug I think...
https://hg.mozilla.org/mozilla-central/rev/b88bbab404c6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: DOM → DOM: Core & HTML

Comment on attachment 9008914 [details]
Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu

Revision D3667 was moved to bug 1601000. Setting attachment 9008914 [details] to obsolete.

Attachment #9008914 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: