Closed
Bug 1491243
Opened 6 years ago
Closed 6 years ago
Remove live bookmark creation UI entrypoints
Categories
(Firefox Graveyard :: RSS Discovery and Preview, enhancement, P1)
Firefox Graveyard
RSS Discovery and Preview
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(2 files)
This bug is for removing the subscribe button, the 'subscribe to feed' menuitems, and any other UI entrypoints that allow creating new live bookmark items.
Assignee | ||
Updated•6 years ago
|
Summary: Remove feed creation UI entrypoints → Remove live bookmark creation UI entrypoints
Assignee | ||
Comment 1•6 years ago
|
||
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.
Comment 2•6 years ago
|
||
Comment on attachment 9009482 [details]
Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r?florian
Florian Quèze [:florian] has approved the revision.
Attachment #9009482 -
Flags: review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d61965849528
remove subscribe button, menu items and subscription section out of feed previews, r=florian
Comment 4•6 years ago
|
||
Backed out changeset d61965849528 (bug 1491243) for en-US failures at testing\firefox-ui\tests\puppeteer\test_page_info_window.py
Backout: https://hg.mozilla.org/integration/autoland/rev/982fd15a017291c6e5ba248afd3f1f662bacdb01
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d6196584952864d2f3354d1ff495e094cd43c9a0&selectedJob=199762289
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199762289&repo=autoland&lineNumber=19963
19:04:36 INFO - 1537211076014 Marionette TRACE 18 -> [0,194,"Marionette:SetContext",{"value":"chrome"}]
19:04:36 INFO - 1537211076014 Marionette TRACE 18 <- [1,194,null,{"value":null}]
19:04:36 INFO - 1537211076015 Marionette TRACE 18 -> [0,195,"Marionette:GetContext",{}]
19:04:36 INFO - 1537211076015 Marionette TRACE 18 <- [1,195,null,{"value":"chrome"}]
19:04:36 INFO - 1537211076016 Marionette TRACE 18 -> [0,196,"Marionette:SetContext",{"value":"content"}]
19:04:36 INFO - 1537211076016 Marionette TRACE 18 <- [1,196,null,{"value":null}]
19:04:36 INFO - 1537211076017 Marionette TRACE 18 -> [0,197,"WebDriver:GetPageSource",{}]
19:04:36 INFO - 1537211076017 Marionette TRACE 18 <- [1,197,{"error":"no such window","message":"Browsing context has been discarded","stacktrace":"WebDriverError@chrome://marion ... et@chrome://marionette/content/server.js:245:8\n_onJSONObjectReady/<@chrome://marionette/content/transport.js:490:9\n"},null]
19:04:36 INFO - 1537211076018 Marionette TRACE 18 -> [0,198,"Marionette:SetContext",{"value":"chrome"}]
19:04:36 INFO - 1537211076018 Marionette TRACE 18 <- [1,198,null,{"value":null}]
19:04:36 WARNING - Failed to gather test failure debug: Browsing context has been discarded
19:04:36 WARNING - stacktrace:
19:04:36 WARNING - WebDriverError@chrome://marionette/content/error.js:178:5
19:04:36 WARNING - NoSuchWindowError@chrome://marionette/content/error.js:410:5
19:04:36 WARNING - assert.that/<@chrome://marionette/content/assert.js:401:13
19:04:36 WARNING - assert.open@chrome://marionette/content/assert.js:157:10
19:04:36 WARNING - GeckoDriver.prototype.getPageSource@chrome://marionette/content/driver.js:1146:15
19:04:36 WARNING - Async*despatch@chrome://marionette/content/server.js:298:20
19:04:36 WARNING - async*execute@chrome://marionette/content/server.js:271:11
19:04:36 WARNING - async*onPacket/<@chrome://marionette/content/server.js:246:15
19:04:36 WARNING - async*onPacket@chrome://marionette/content/server.js:245:8
19:04:36 WARNING - _onJSONObjectReady/<@chrome://marionette/content/transport.js:490:9
19:04:36 WARNING -
19:04:36 INFO - TEST-UNEXPECTED-ERROR | testing\firefox-ui\tests\puppeteer\test_page_info_window.py TestPageInfoWindow.test_elements | NoSuchElementException: Unable to locate element: feedPanel
19:04:36 INFO - stacktrace:
19:04:36 INFO - WebDriverError@chrome://marionette/content/error.js:178:5
19:04:36 INFO - NoSuchElementError@chrome://marionette/content/error.js:388:5
19:04:36 INFO - element.find/</<@chrome://marionette/content/element.js:339:16
19:04:36 INFO - Traceback (most recent call last):
19:04:36 INFO - File "Z:\task_1537209690\build\venv\lib\site-packages\marionette_harness\marionette_test\testcases.py", line 159, in run
19:04:36 INFO - testMethod()
19:04:36 INFO - File "Z:\task_1537209690\build\tests\firefox-ui\tests\testing\firefox-ui\tests\puppeteer\test_page_info_window.py", line 27, in test_elements
19:04:36 INFO - self.assertEqual(page_info.deck.feed.element.get_property('localName'), 'vbox')
19:04:36 INFO - File "Z:\task_1537209690\build\venv\lib\site-packages\firefox_puppeteer\ui\pageinfo\deck.py", line 40, in feed
19:04:36 INFO - return self._create_panel_for_id('feedPanel')
19:04:36 INFO - File "Z:\task_1537209690\build\venv\lib\site-packages\firefox_puppeteer\ui\pageinfo\deck.py", line 29, in _create_panel_for_id
19:04:36 INFO - panel = self.element.find_element(By.ID, panel_id)
19:04:36 INFO - File "Z:\task_1537209690\build\venv\lib\site-packages\marionette_driver\marionette.py", line 57, in find_element
19:04:36 INFO - return self.marionette.find_element(method, target, self.id)
19:04:36 INFO - File "Z:\task_1537209690\build\venv\lib\site-packages\marionette_driver\marionette.py", line 1793, in find_element
19:04:36 INFO - body, key="value")
19:04:36 INFO - File "Z:\task_1537209690\build\venv\lib\site-packages\marionette_driver\decorators.py", line 26, in _
19:04:36 INFO - return func(*args, **kwargs)
19:04:36 INFO - File "Z:\task_1537209690\build\venv\lib\site-packages\marionette_driver\marionette.py", line 759, in _send_message
19:04:36 INFO - self._handle_error(err)
19:04:36 INFO - File "Z:\task_1537209690\build\venv\lib\site-packages\marionette_driver\marionette.py", line 779, in _handle_error
19:04:36 INFO - raise errors.lookup(error)(message, stacktrace=stacktrace)
19:04:36 INFO - TEST-INFO took 325ms
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Cristina Coroiu [:ccoroiu] from comment #4)
> Backed out changeset d61965849528 (bug 1491243) for en-US failures at
> testing\firefox-ui\tests\puppeteer\test_page_info_window.py
Ugh. I pushed to try until I did the page info changes, and adapting the browser tests for that I was pretty confident that those were the only tests... I don't really understand why we have these puppeteer tests, but oh well... I guess I get to remove the feed code from there, too - it doesn't look like the implementation actually does anything (the class is empty).
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 6•6 years ago
|
||
Depends on D5982
Comment 7•6 years ago
|
||
Comment on attachment 9009736 [details]
Bug 1491243 - remove feed bits from puppeteer page info code, r?whimboo
Henrik Skupin (:whimboo) has approved the revision.
Attachment #9009736 -
Flags: review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/525cd5af1b3f
remove subscribe button, menu items and subscription section out of feed previews, r=florian
https://hg.mozilla.org/integration/autoland/rev/bd9554dc0451
remove feed bits from puppeteer page info code, r=whimboo
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/525cd5af1b3f
https://hg.mozilla.org/mozilla-central/rev/bd9554dc0451
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•