Closed Bug 1491255 Opened 6 years ago Closed 6 years ago

Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 3 obsolete files)

+++ This bug was initially created as a clone of Bug #1491252 +++ See trimValue in urlbarBindings.xml.
Assignee: nobody → dao+bmo
Blocks: 1491245
Status: NEW → ASSIGNED
Priority: P2 → P1
Attached patch patch (obsolete) (deleted) — Splinter Review
This makes browser/base/content/test/urlbar/browser_urlbarTrimURLs.js pass
Attachment #9011737 - Flags: review?(standard8)
Attached patch patch (obsolete) (deleted) — Splinter Review
test_UrlbarInput_unit.js fixed
Attachment #9011737 - Attachment is obsolete: true
Attachment #9011737 - Flags: review?(standard8)
Attachment #9011756 - Flags: review?(standard8)
Comment on attachment 9011756 [details] [diff] [review] patch Review of attachment 9011756 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/urlbar/UrlbarPrefs.jsm @@ +170,5 @@ > * Returns the value for the preference with the given name. > * > * @param {string} pref > * The name of the preference to get. > + * @returns {string} The preference value. Digging into this, I think we currently return strings, arrays, booleans and integers. So we could make the value `{string|array|boolean|number}`, but I'm wonder if it is just better to go with `{*}` - basically admit it could be almost anything. (same with the changes below).
Attachment #9011756 - Flags: review?(standard8) → review+
Attached patch patch v2 (obsolete) (deleted) — Splinter Review
Attachment #9011756 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by nerli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8cb351adc7d3 Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
Keywords: checkin-needed
Backout by aiakab@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d7a945fc6271 Backed out changeset 8cb351adc7d3 for failing test verify on browser_urlbarTrimURLs.js
Blocks: 1494334
Attached patch patch v3 (deleted) — Splinter Review
Attachment #9012170 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/184a229a8cc4 Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Blocks: 1494274
Depends on: 1498879
Depends on: 1500080
Blocks: 1501996
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: