Bryan told me that the Shield icon should be a bit larger. See this screenshot.

Bryan, this is because the icon you provided has a bit of space on the sides. Can you upload one without? Thanks!

(In reply to Johann Hofmann [:johannh] from comment #1) > Bryan, this is because the icon you provided has a bit of space on the > sides. Can you upload one without? > > Thanks! My patch works around it. The security icon has the same problem... (Or we could fix both icons. If they both are made 24x24 and fill in the entire canvas then the problem would go away -- if that size if fine.)

(In reply to :Ehsan Akhgari from comment #4) > (In reply to Johann Hofmann [:johannh] from comment #1) > > Bryan, this is because the icon you provided has a bit of space on the > > sides. Can you upload one without? > > > > Thanks! > > My patch works around it. The security icon has the same problem... > > (Or we could fix both icons. If they both are made 24x24 and fill in the > entire canvas then the problem would go away -- if that size if fine.) Yeah, see comment on Phabricator (this is why comments should be mirrored), I think that's the preferable solution. We don't use that icon anywhere else.

here's the replacement icon you need.

and one for the lock icon

Pascal, is it too late to update icons for 63?

If you land on nightly like today and request uplift in the process, I can look at that uplift request tomorrow or Monday morning before the merge (no promise though, we have several last minute uplift requests and we also need to minimize risk)

Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc9eacb12437 Update the security and content blocking icons in the control centre r=johannh

Sorry, this landed a bit late. I'll nominate for uplift, but please feel free to say no if this throws a wrench into the release plans, no pressure. :-) Thanks!

Comment on attachment 9016882 [details] Bug 1491455 - Update the security and content blocking icons in the control centre [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Unclear User impact if declined: The Security and Content Blocking icons appear a bit squished in the control centre Is this code covered by automated tests?: No Has the fix been verified in Nightly?: No Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Icon update String changes made/needed: None

Comment on attachment 9016882 [details] Bug 1491455 - Update the security and content blocking icons in the control centre Hi Ehsan, it's a bit late indeed as the patch isn't even on Nightly and we will build rc1 soon. The visual change is also very subtle so I think it can ride the trains and I also noticed in your second screenshot that the lock icon in the url bar seems now more different from the one in the doorhanger which is maybe unwanted from a UX perspective (maybe chrome://browser/skin/connection-secure.svg should be updated too?).

Screenshot comparison: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=b569fad5a51ff187f7a03e584ba3e5910e0f19ee&newProject=mozilla-central&newRev=c1ee6c65f85b0ea68006a3802db0937220d55da3&filter=controlCenter I filed bug 1499279 for a regression to the grey lock icon state across all platforms so that should probably be fixed before any uplift.