Closed
Bug 1491676
Opened 6 years ago
Closed 6 years ago
Move strings from preferences.properties to Fluent
Categories
(Firefox :: Settings UI, enhancement, P3)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: jaws, Assigned: jack, Mentored)
References
Details
Attachments
(5 files, 2 obsolete files)
When viewing about:preferences with intl.l10n.pseudo=accented, the strings in the Applications list are not localized (Always ask, Preview in %S, ...).
All the strings in preferences.properties should be migrated to Fluent.
Reporter | ||
Comment 1•6 years ago
|
||
Please also merge https://searchfox.org/mozilla-central/rev/7a91966c106a3dde924e040b4e5b72d33eb77bf7/toolkit/components/cloudstorage/content/preferences.properties in to the same Fluent file.
Reporter | ||
Comment 2•6 years ago
|
||
You should end up with one FTL file in /toolkit/locales and one in /browser/locales.
browser/locales should have the strings from:
browser/locales/en-US/chrome/browser/preferences/preferences.properties
toolkit/locales should have the strings from:
toolkit/locales/en-US/chrome/mozapps/preferences/preferences.properties
toolkit/components/cloudstorage/content/preferences.properties
The cloudstorage one was in a separate properties file (not localized) since it looks like the feature might not be shipping to all users but we should just merge it in since it's only one string and we won't have to load a separate .properties file for it.
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → jack
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•6 years ago
|
||
Zibi, do you know why this file was not covered in the preferences -> ftl migration?
Flags: needinfo?(gandalf)
Assignee | ||
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
> Zibi, do you know why this file was not covered in the preferences -> ftl migration?
At the time when I was migrating Preferences some of the strings were used both in Preferences and outside of it. Since we were only migrating Preferences, I didn't want to touch them.
In a couple cases the XBL made it hard to migrate to Fluent, but those cases seems to be refactored out of complex XBL already.
In other words - I think those strings can be now migrated.
Flags: needinfo?(gandalf)
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Depends on D8552
Assignee | ||
Comment 8•6 years ago
|
||
Depends on D8553
Assignee | ||
Comment 9•6 years ago
|
||
Depends on D8554
Assignee | ||
Comment 10•6 years ago
|
||
Depends on D8928
Comment 11•6 years ago
|
||
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a448725f676
Moves cloudstorage string r=flod,Gijs
Comment 12•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 13•6 years ago
|
||
Reopening, since the queue still needs to land
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•6 years ago
|
Assignee | ||
Comment 14•6 years ago
|
||
Depends on D9917
Updated•6 years ago
|
Attachment #9014616 -
Attachment is obsolete: true
Comment 15•6 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/76ea995336dc
Moves master password dialog strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/eb19b384d908
Moves out of space warning strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/04b83b7977c4
Moves download folder strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/e860d0d115d0
Moves permissions strings r=flod,Gijs,zbraniecki
Comment 16•6 years ago
|
||
Backed out 4 changesets (bug 1491676) for browser-chrome permissions failures
push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&selectedJob=210284622&revision=e860d0d115d04d12cbc60723c40cd38671305946
failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&selectedJob=210287266&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-4%2Cm-e10s%28bc4%29
backout: https://hg.mozilla.org/integration/autoland/rev/b5e996a1d34b48ae37d30f51d2f19de8f9c7f517
Flags: needinfo?(gijskruitbosch+bugs)
Updated•6 years ago
|
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(jack)
Updated•6 years ago
|
Flags: needinfo?(jack)
Comment 17•6 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e75c59f129ea
Moves master password dialog strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/aeb045b90321
Moves out of space warning strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/fae949de1ed5
Moves download folder strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/08cbaa2f9183
Moves permissions strings r=flod,Gijs,zbraniecki
Comment 18•6 years ago
|
||
Backed out for causing browser chrome failures on browser_storagePressure_notification.
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed&fromchange=08cbaa2f918394d8eafc833bbb148f6b41e500a8&tochange=0137b019c6fae65a0d1356151e617352755c8c9c&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-13%2Cm-e10s%28bc13%29&selectedJob=210374315
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=210374315&repo=autoland&lineNumber=2206
Backout link: https://hg.mozilla.org/integration/autoland/rev/0137b019c6fae65a0d1356151e617352755c8c9c
[task 2018-11-07T18:39:03.495Z] 18:39:03 INFO - TEST-START | browser/base/content/test/general/browser_storagePressure_notification.js
[task 2018-11-07T18:39:03.600Z] 18:39:03 INFO - TEST-INFO | started process screentopng
[task 2018-11-07T18:39:04.232Z] 18:39:04 INFO - TEST-INFO | screentopng: exit 0
[task 2018-11-07T18:39:04.234Z] 18:39:04 INFO - Buffered messages logged at 18:39:03
[task 2018-11-07T18:39:04.236Z] 18:39:04 INFO - Entering test bound
[task 2018-11-07T18:39:04.238Z] 18:39:04 INFO - Buffered messages finished
[task 2018-11-07T18:39:04.239Z] 18:39:04 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_storagePressure_notification.js | Should display storage pressure notification -
[task 2018-11-07T18:39:04.241Z] 18:39:04 INFO - Stack trace:
[task 2018-11-07T18:39:04.244Z] 18:39:04 INFO - chrome://mochikit/content/browser-test.js:test_ok:1297
[task 2018-11-07T18:39:04.246Z] 18:39:04 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_storagePressure_notification.js:null:33
[task 2018-11-07T18:39:04.247Z] 18:39:04 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
[task 2018-11-07T18:39:04.249Z] 18:39:04 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089
[task 2018-11-07T18:39:04.250Z] 18:39:04 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:987
[task 2018-11-07T18:39:04.252Z] 18:39:04 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2018-11-07T18:39:04.254Z] 18:39:04 INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-07T18:39:04.254Z] 18:39:04 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_storagePressure_notification.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/general/browser_storagePressure_notification.js:34 - TypeError: notification is null; can't access its "close" property
[task 2018-11-07T18:39:04.254Z] 18:39:04 INFO - Stack trace:
[task 2018-11-07T18:39:04.254Z] 18:39:04 INFO - @chrome://mochitests/content/browser/browser/base/content/test/general/browser_storagePressure_notification.js:34:3
[task 2018-11-07T18:39:04.254Z] 18:39:04 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1098:34
[task 2018-11-07T18:39:04.254Z] 18:39:04 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1089:16
[task 2018-11-07T18:39:04.255Z] 18:39:04 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:987:9
[task 2018-11-07T18:39:04.255Z] 18:39:04 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
[task 2018-11-07T18:39:04.255Z] 18:39:04 INFO - Leaving test bound
[task 2018-11-07T18:39:04.255Z] 18:39:04 INFO - Entering test bound
Flags: needinfo?(jack)
Comment 19•6 years ago
|
||
Please also take a look over this failure: https://treeherder.mozilla.org/logviewer.html#?job_id=210374638&repo=autoland&lineNumber=11053
10:42:08 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_cookies_exceptions.js | All expectedStyleSheetURLs should have been found -
10:42:08 INFO - Buffered messages finished
10:42:08 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_cookies_exceptions.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_cookies_exceptions.js:275 - TypeError: win.gPermissionManager._getCapabilityString is not a function
10:42:08 INFO - Stack trace:
10:42:08 INFO - runTest@chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_cookies_exceptions.js:275:16
10:42:08 INFO - async*testAllow@chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_cookies_exceptions.js:7:9
10:42:08 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1098:34
10:42:08 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1089:16
10:42:08 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:987:9
10:42:08 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
10:42:08 INFO - Leaving test bound testAllow
10:42:08 INFO - Entering test bound testBlock
Reporter | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Comment 20•6 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dc9fd82a26a5
Moves master password dialog strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/b7b03bffac5e
Moves out of space warning strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/a7afdb6ab503
Moves download folder strings r=flod,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/d364b0b15fa5
Moves permissions strings r=flod,Gijs,zbraniecki
Comment 21•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dc9fd82a26a5
https://hg.mozilla.org/mozilla-central/rev/b7b03bffac5e
https://hg.mozilla.org/mozilla-central/rev/a7afdb6ab503
https://hg.mozilla.org/mozilla-central/rev/d364b0b15fa5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(jack)
Updated•6 years ago
|
Attachment #9021335 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•