Closed
Bug 1491783
Opened 6 years ago
Closed 6 years ago
Lighten file sharing mode during SignedBinary::VerifySignature
Categories
(Firefox :: General, enhancement, P2)
Tracking
()
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: ccorcoran, Assigned: ccorcoran)
References
Details
Attachments
(1 file)
Right now we currently only have FILE_SHARE_READ sharing mode (https://searchfox.org/mozilla-central/rev/bdc89dfd7869e418d788b28eb60ab8d94e708a15/mozglue/build/Authenticode.cpp#268), but I propose adding FILE_SHARE_DELETE | FILE_SHARE_WRITE, to slightly reduce impact.
The specific need is related to interaction between bug 1435827 and toolkit/components/ctypes/tests/chrome/test_ctypes.xul. This test attempts to delete a DLL that was loaded into the process, but bug 1435827 is at the same time examining its digital signature, causing the delete to fail.
Adding the appropriate file sharing mode will allow the file to be deleted more often. Though the later call to WinVerifyTrust() internally maps a view of the file with PAGE_READ_EXECUTE which also causes the delete to fail, but that can't be prevented.
We already do sufficient error checking, so just adding the flags appears to work fine.
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9009568 [details]
Bug 1491783: Allow file delete and write during VerifySignature;r=aklotz
Aaron Klotz [:aklotz] has approved the revision.
Attachment #9009568 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/45ae214ae159
Allow file delete and write during VerifySignature;r=aklotz
Keywords: checkin-needed
Comment 4•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•