Closed
Bug 1491853
(as-mc)
Opened 6 years ago
Closed 5 years ago
m-c developers should be able to easily get started with in-tree AS development
Categories
(Firefox :: Messaging System, enhancement, P3)
Firefox
Messaging System
Tracking
()
RESOLVED
DUPLICATE
of bug 1552007
People
(Reporter: dmosedale, Unassigned)
References
(Blocks 1 open bug)
Details
I believe this already more or less works because of the completion of bug 1440421. The main thing to do is probably to add a README.mozilla-central file of some sort, which details how (probably including npm install, and maybe other stuff too).
Perhaps it wants to be an .rst file so that it gets included in firefox-source-docs.mozilla.org, but I would guess that the usual context it's going to be read is just people inside the tree at their command-line or text editor, so plain-text might be best.
Reporter | ||
Updated•6 years ago
|
Blocks: as-build-meta
Reporter | ||
Updated•6 years ago
|
Alias: as-mc
Updated•6 years ago
|
Iteration: --- → 64.2 (Sep 28)
status-firefox63:
--- → wontfix
status-firefox64:
--- → affected
Priority: -- → P2
Updated•6 years ago
|
Iteration: 64.2 (Sep 28) → 64.3 (Oct 12)
Reporter | ||
Comment 1•6 years ago
|
||
This involves documenting / fixing any issues related to executing npm and doing development directly in browser/components/newtab. One problem in particular that I think has been hit by both Standard8 and Mardak is that right now, husky installs github hooks for the git repo. This makes sense for working in the activity-stream repo directly, but does the wrong thing for folks who pull mozilla-central from git: it installs the hooks to be run on all mozilla-central commits. I'm not sure what the exact consequences of that are. Standard8?
Adding :k88hudson to the CC, as I suspect she may have opinions on what we do here...
Flags: needinfo?(standard8)
Comment 2•6 years ago
|
||
(In reply to Dan Mosedale (:dmose, :dmosedale) from comment #1)
> I'm not sure what the exact consequences of that are. Standard8?
Well in my case, husky complained that `npm-run-all` wasn't installed so I couldn't push patches (e.g. to try), and I spent quite a while trying to work out where it was coming from.
Flags: needinfo?(standard8)
Updated•6 years ago
|
Iteration: 64.3 (Oct 12) → 65.1 (Nov 2)
Updated•6 years ago
|
Iteration: 65.1 (Nov 2) → 65.2 (Nov 16)
Updated•6 years ago
|
Iteration: 65.2 (Nov 16) → 65.3 (Nov 30)
Updated•6 years ago
|
Iteration: 65.3 (Nov 30) → 65.4 - Dec 3-9
Updated•6 years ago
|
Iteration: 65.4 - Dec 3-9 → ---
Priority: P2 → P3
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•