Closed Bug 1491925 Opened 6 years ago Closed 6 years ago

Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 and bug 1501479 and bug 1503664 and bug 1505468 are adding before it gets to release

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 blocking verified
firefox65 blocking verified

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug,
URL
)

Details

Crash Data

Attachments

(1 file)

Remove the various instrumentation we added to pin down InnerSetNewDocument failures
(deleted), patch
mccr8
: review+
Details | Diff | Splinter Review
[Tracking Requested - why for this release]:
Priority: -- → P2
Crash Signature: [@ JS::Compartment::getOrCreateWrapper ]
status-firefox62: --- → unaffected
status-firefox63: --- → unaffected
status-firefox64: --- → affected
status-firefox-esr60: --- → unaffected
tracking-firefox64: ? → blocking
Blocks: 1493849
No longer blocks: 1491313
Summary: Remove the instrumentation bug 1491313 is adding before it gets to release → Remove the instrumentation bug 1493849 is adding before it gets to release
mozilla::dom::HTMLDocument_Binding::Wrap crashes say "MOZ_CRASH(Looks like bug 1488480/1405521, with HTMLDocument not having a proto)".
Crash Signature: [@ JS::Compartment::getOrCreateWrapper ] → [@ JS::Compartment::getOrCreateWrapper ] [@ mozilla::dom::HTMLDocument_Binding::Wrap ]
QA Contact: overholt
Blocks: 1496805
Summary: Remove the instrumentation bug 1493849 is adding before it gets to release → Remove the instrumentation bug 1493849 and bug 1496805 are adding before it gets to release
QA Contact: overholt
See bug 1493849 comment 8 for an analysis of the bit from comment 1 and bug 1496805 for a further attempt at diagnosis.
Crash Signature: [@ JS::Compartment::getOrCreateWrapper ] [@ mozilla::dom::HTMLDocument_Binding::Wrap ] → [@ JS::Compartment::getOrCreateWrapper ] [@ mozilla::dom::HTMLDocument_Binding::Wrap ] [@ mozilla::dom::HTMLDocument_Binding::CreateInterfaceObjects ]
Blocks: 1499150
Summary: Remove the instrumentation bug 1493849 and bug 1496805 are adding before it gets to release → Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 are adding before it gets to release
Blocks: 1501479
Summary: Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 are adding before it gets to release → Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 and bug 1501479 are adding before it gets to release
I spun off bug 1503659 on doing the backout from Gecko 64.
URL: https://bugzilla.mozilla.org/show_bug...
status-firefox65: --- → affected
tracking-firefox65: --- → blocking
Blocks: 1503664
Summary: Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 and bug 1501479 are adding before it gets to release → Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 and bug 1501479 and bug 1503664 are adding before it gets to release
Blocks: 1505468
Summary: Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 and bug 1501479 and bug 1503664 are adding before it gets to release → Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 and bug 1501479 and bug 1503664 and bug 1505468 are adding before it gets to release
This is a straight backout of (in that order) bug 1505468, bug 1503664, bug 1501479, bug 1499150, bug 1496805, and the second part of bug 1493849. The first part of bug 1493849 was a backout of earlier instrumentation, and that should stay. At this point we know we're hitting OOM inside the JS engine while trying to define properties on Document.prototype, so all this MOZ_CRASH instrumentation is no longer needed.
Attachment #9028012 - Flags: review?(continuation)
Comment on attachment 9028012 [details] [diff] [review] Remove the various instrumentation we added to pin down InnerSetNewDocument failures Review of attachment 9028012 [details] [diff] [review]: ----------------------------------------------------------------- Whoops, I guess I didn't actually finish my review yesterday. Sorry about that.
Attachment #9028012 - Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d321a6c5e071 Remove the various instrumentation we added to pin down InnerSetNewDocument failures. r=mccr8.
https://hg.mozilla.org/mozilla-central/rev/d321a6c5e071
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Depends on: 1513179
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
status-firefox65: fixed → verified
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: