We change the engine record to use `overrideTelemetryName` when it's finished syncing, but before validation runs. This causes us to miss the validation result, along with an error complaining that the engine hasn't been synced. I think this is why we haven't seen pings for `bookmarks-buffered` in telemetry.

Comment on attachment 9009801 [details] Ensure Sync engines with overridden telemetry names correctly report their validation results. Thom Chiovoloni [:tcsc] has approved the revision.

Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8320750a187e Ensure Sync engines with overridden telemetry names correctly report their validation results. r=tcsc

Did you want to nominate this for Beta uplift?

Comment on attachment 9009801 [details] Ensure Sync engines with overridden telemetry names correctly report their validation results. Approval Request Comment [Feature/Bug causing the regression]: Bug 1405205. [User impact if declined]: We won't be able to collect telemetry data for new bookmark sync on Beta, necessary for the next phase of the Shield study (bug 1456221). [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Yes. Validation pings for the new engine show up in STMO now. \o/ [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No. [Why is the change risky/not risky?]: The change to the Sync telemetry code is small in scope, includes an xpcshell test, and has been manually verified. [String changes made/needed]: None.

Comment on attachment 9009801 [details] Ensure Sync engines with overridden telemetry names correctly report their validation results. Uplift approved for 63 beta 8, thanks.