Closed Bug 1492131 Opened 6 years ago Closed 6 years ago

Parallax scrolling broken with webrender enabled

Categories

(Core :: Graphics: WebRender, defect, P2)

64 Branch
x86_64
All
defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- disabled
firefox63 --- disabled
firefox64 --- disabled
firefox65 --- fixed

People

(Reporter: alberts, Assigned: sotaro)

References

(Blocks 1 open bug, )

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

1) Go to: http://www.abc.net.au/news/2018-09-18/china-social-credit-a-model-citizen-in-a-digital-dictatorship/10200278 2) You see a video in full viewport 3) scroll down Expected: See the Article title block scrolling over the video and the next section (video) appear underneath/behind the title block. Actual: When scrolling down while webrender is enabled the page directly jumps to the next section without displaying the title at all. It is also not possible to scroll back up.
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86_64
This is due to the rule: .Block-media.is-fixed { clip: rect(0,auto,auto,0); -webkit-clip-path: inset(0 0 0 0); } Fwiw making -webkit-clip-path -> clip-path (which we support) it works. So it smells like something related to the `auto` in that clip definition.
Priority: -- → P3
It works in non-WebRender, so the "auto" is probably unrelated. It's either a WebRender bug or a bug in WebRenderCommandBuilder's clip translation, I'd say. The clip property translates to a rectangle DisplayItemClip on the display item, whereas the clip-path property translates to an nsDisplayMask which translates to a WR image clip.
Debian Testing, KDE, Xorg, GTX 1060 Are elements just in the wrong order? Videos might not have played in "last good" because of bug 1482727. "Good" is when we see a white title on a black background, a video with people in boxes and are able to scroll down and then up again. mozregression --good 2018-04-15 --bad 2018-09-19 --pref gfx.webrender.all:true -a http://www.abc.net.au/news/2018-09-18/china-social-credit-a-model-citizen-in-a-digital-dictatorship/10200278 > 11:29.87 INFO: Last good revision: b0c68c17915159517e82c04b26801ff3869f61be > 11:29.87 INFO: First bad revision: 573a198b7fdf076e27eb1f468162df101246d7b3 > 11:29.87 INFO: Pushlog: > https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b0c68c17915159517e82c04b26801ff3869f61be&tochange=573a198b7fdf076e27eb1f468162df101246d7b3 > 573a198b7fdf Jean-Yves Avenard — Bug 1435212 - Add support for FFmpeg 4.0. r=bryce mozregression --repo mozilla-inbound --good 2018-04-18 --bad 2018-04-19 --pref gfx.webrender.all:true -a http://www.abc.net.au/news/2018-09-18/china-social-credit-a-model-citizen-in-a-digital-dictatorship/10200278 > 10:57.31 INFO: Last good revision: b0c68c17915159517e82c04b26801ff3869f61be > 10:57.31 INFO: First bad revision: 573a198b7fdf076e27eb1f468162df101246d7b3 > 10:57.31 INFO: Pushlog: > https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b0c68c17915159517e82c04b26801ff3869f61be&tochange=573a198b7fdf076e27eb1f468162df101246d7b3 > 573a198b7fdf Jean-Yves Avenard — Bug 1435212 - Add support for FFmpeg 4.0. r=bryce Let's disable ffmpeg... mozregression --repo autoland --good 2018-04-18 --bad 2018-04-19 --pref gfx.webrender.all:true media.ffmpeg.enabled:false -a http://www.abc.net.au/news/2018-09-18/china-social-credit-a-model-citizen-in-a-digital-dictatorship/10200278 > 2:00.03 ERROR: Build was expected to be bad! The initial good/bad range seems incorrect. everything is good, wtf? mozregression --good 2018-04-15 --bad 2018-09-19 --pref gfx.webrender.all:true media.ffmpeg.enabled:false -a http://www.abc.net.au/news/2018-09-18/china-social-credit-a-model-citizen-in-a-digital-dictatorship/10200278 > 1:16.15 ERROR: Build was expected to be bad! The initial good/bad range seems incorrect. This page is fine in today's Nightly with WebRender if I disable media.ffmpeg.enabled. I don't need to restart Nightly. What is going on?
No, the videos should be hidden by the clip that wraps them, not by elements on top that cover them. I don't know what the relation to ffmpeg is.
> Videos might not have played in "last good" because of bug 1482727. This assumption might be wrong. "last good" looks the same as disabling media.ffmpeg.enabled today. Videos are just static images then, the rest of the page looks okay.
Win10, GTX 1060 Windows was already bad on 2018-01-15. If I disable media.wmf.enabled or media.mp4.enabled, videos are just static images, but the page looks otherwise fine.
OS: Mac OS X → All
Priority: P3 → P2
Attached video 2018-09-20 23-45-38.mp4 (deleted) —
Nightly 20180920100522, left=non-WR, right=WR
Win10, GTX1060 mozregression --good 2017-04-10 --bad 2017-07-10 --pref gfx.webrender.enabled:true -a http://www.abc.net.au/news/2018-09-18/china-social-credit-a-model-citizen-in-a-digital-dictatorship/10200278 -a about:support > 3:36.64 INFO: Got as far as we can go bisecting nightlies... > 3:36.64 INFO: Last good revision: 95543bdc59bd038a3d5d084b85a4fec493c349ee (2017-06-19) > 3:36.64 INFO: First bad revision: 7a6baa6cca3292e8099e652b64d27e74df560874 (2017-06-20) > 3:36.64 INFO: Pushlog: > https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=95543bdc59bd038a3d5d084b85a4fec493c349ee&tochange=7a6baa6cca3292e8099e652b64d27e74df560874 [...] > 5:46.50 INFO: There are no build artifacts on inbound for these changesets (they are probably too old).
Priority: P2 → P3
Priority: P3 → P2
Turning off APZ seems to fix this somehow, at least on my macOS build.
:alberts, can you still reproduce the problem with latest nightly?
Flags: needinfo?(albert)
Assignee: nobody → sotaro.ikeda.g
Works like a charm!
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(albert)
Resolution: --- → FIXED
Depends on: 1507848
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: