Closed
Bug 1492247
Opened 6 years ago
Closed 6 years ago
Fix exception in browser.xhtml when opening findbar "Error: Attempt to inject localization link before document.head is available"
Categories
(Core :: Internationalization, enhancement)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
Our helper function insertFTLIfNeeded assumes that document.head will be present in HTML docs. In browser.xhtml that's not the case, so we can either add a head tag there or make the function detect HTML documents in a different way.
|
Assignee | |
Comment 1•6 years ago
|
||
This prevents an exception in browser.xhtml when there's no head, since it's currently sharing the markup with browser.xul.
|
||
Updated•6 years ago
|
Attachment #9010055 -
Attachment description: Bug 1492247 - Allow for null document.head when inserting localization links;r=zbraniecki → Bug 1492247 - Allow for null document.head in browser.xhtml inserting localization links;r=zbraniecki
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9010055 [details] Bug 1492247 - Allow for null document.head in browser.xhtml inserting localization links;r=zbraniecki Zibi Braniecki [:gandalf][:zibi] has approved the revision.
Attachment #9010055 -
Flags: review+
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3857cbe7b717 Allow for null document.head in browser.xhtml inserting localization links;r=zbraniecki
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3857cbe7b717
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
|
Assignee | |
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•