Closed
Bug 1492284
Opened 6 years ago
Closed 6 years ago
Use sharedWorkspace.notificationCenter for Mojave instead of defaultCenter
Categories
(Core :: Widget: Cocoa, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla64
People
(Reporter: hiro, Assigned: hiro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
mstange
:
review+
pascalc
:
approval-mozilla-beta+
|
Details |
As per bug 1486971 comment 30, we need to use sharedWorkspace.notificationCenter for Mojave (or later versions) to get the accessibilityDisplayShouldReduceMotion changes instead of defaultCenter.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
On Mojave (or later versions) defaultCenter doesn't get the
accessibilityDisplayShouldReduceMotion changes, we need to use
sharedWorkspace.notificationCenter instead.
Note that the reason why we use defaultCenter originally is that using
sharedWorkspace.notificationCenter to post a notification (for mochitest)
crashed on MacOSX 10.10 (on a try).
Comment 3•6 years ago
|
||
Regarding the dependency on bug 1384336 "Avoid running the appshell in content processes", in case it isn't clear, that fix was landed for Mac with bug 1426100 which is in build 63. If this bug blocks 1426100, we'll need it in 63.
Comment 4•6 years ago
|
||
Comment on attachment 9010073 [details]
Bug 1492284 - sharedWorkspace.notificationCenter for Mojave to get the accessibilityDisplayShouldReduceMotion changes. r=mstange
Markus Stange [:mstange] has approved the revision.
Attachment #9010073 -
Flags: review+
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e570bfcc0ea1
sharedWorkspace.notificationCenter for Mojave to get the accessibilityDisplayShouldReduceMotion changes. r=mstange
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 9010073 [details]
Bug 1492284 - sharedWorkspace.notificationCenter for Mojave to get the accessibilityDisplayShouldReduceMotion changes. r=mstange
Approval Request Comment
[Feature/Bug causing the regression]: None
[User impact if declined]: Similar to bug 1486971, but users on MacOSX 10.14 won't see prefers-reduced-motion changes until the browser restarts
[Is this code covered by automated tests?]: Yes, a test in bug 1486971 covers this but we haven't run it on MacOSX 10.14 on our infra
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: The change is guarded by OS version checks and a contributor (Sören) has confirmed it works fine on MacOSX 10.14 (in bug 1486971 comment 30)
[String changes made/needed]: None
Attachment #9010073 -
Flags: approval-mozilla-beta?
Comment 8•6 years ago
|
||
Comment on attachment 9010073 [details]
Bug 1492284 - sharedWorkspace.notificationCenter for Mojave to get the accessibilityDisplayShouldReduceMotion changes. r=mstange
P1, verified on Nightly + Mojave ships today, uplift approved for 63 beta 9, thanks.
Attachment #9010073 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•6 years ago
|
||
bugherder uplift |
status-firefox63:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•