Closed
Bug 1492327
Opened 6 years ago
Closed 6 years ago
browser.xhtml: focus is wrong in various tests
Categories
(Firefox :: General, enhancement, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: bdahl, Assigned: bdahl)
References
Details
Attachments
(1 file)
browser_popupNotification_keyboard.js was failing with browser.xhtml
This was caused by document.activeElement behaving differently in XUL and HTML. We should roll back the changes in bug 1485157 and fix activeElement.
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
If we were able to create a <head>/<body> element for browser.xhtml would that allow us to skip the nsDocument change there? Or is it important that we return the documentElement instead of the body anyway?
Updated•6 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #2)
> If we were able to create a <head>/<body> element for browser.xhtml would
> that allow us to skip the nsDocument change there? Or is it important that
> we return the documentElement instead of the body anyway?
I'm unsure, will need to do some testing.
Updated•6 years ago
|
Priority: -- → P3
Updated•6 years ago
|
Assignee | ||
Comment 4•6 years ago
|
||
Return the document element as the activeElement when there is no body
element, the document is chrome privileged, and the document element
is a XUL element.
MozReview-Commit-ID: JFDLAqOmLTS
Comment 5•6 years ago
|
||
Comment on attachment 9010809 [details]
Bug 1492327 - Mimic XUL activeElement behavior for XUL in XHTML. r=gijs
Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9010809 -
Flags: review+
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fee2deb0567
Mimic XUL activeElement behavior for XUL in XHTML. r=smaug
Comment 7•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Assignee | ||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•