Looking at https://hg.mozilla.org/mozilla-central/rev/6dd5d0b6ba70 there seem to be two patterns we need to replace: -menulist.menuBoxObject.activeChild = currentOption; +menulist.activeChild = currentOption; and -aMenuBtn.boxObject.openMenu(true); +aMenuBtn.openMenu(true); Let me try that on C-C.

Try without the patch: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ae1a6c4ced519dcd88cb4dcd9ebff5e0da0d48b5 Try with the patch: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=806cba3267416dfdc7cdb7d2764a3880076477e1

Oops, |instanceof MenuBoxObject| needed replacement, too. And |ChromeUtils.getClassName(targetNode) == "XULElement"| only found in suite/. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a46faa3162938e3c3de9e30f37a6c3df89c1f1ad FRG, should I land the suite/ changes here or do you prefer another bug?

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/91c8e34b5a10 Port Bug 1465219: Replace MenuBoxObject with XULElement subclass. rs=bustage-fix

Sadly both tries are green, so back to manual testing. Editable menulists: - Edit from address, fiddled with this, eventually I saw: this.menuBoxObject is undefined; can't access its "activeChild" property The patch fixes that. The code in mailWidgets.xml is for "Folder picker helper widgets". Sorry, I can't find a way to trigger that. And the date picker isn't used in TB, only in add-ons :-(

Comment on attachment 9010346 [details] [diff] [review] 1492522-MenuBoxObject.patch (v2) OK, I've landed the TB part only. One hunk was certainly correct, not so sure about the other two which I couldn't test.

This is Jonathan Kamens "Datepicker Bug Reproducer" add-on ported to legacy WE. Somehow it doesn't automatically load the panel, bu that can be done in the error console with: openDialog("chrome://dtpr/content/dialog.xul", "_blank", "chrome,titlebar,modal,resizable", null); The datepicker works (sort of, the month doesn't change in the pop-up). Without the patch I get: JavaScript error: chrome://messenger/content/datetimepicker.xml, line 1262: ReferenceError: MenuBoxObject is not defined. With the patch there's no such error.

Filed bug 1492560 for the month that doesn't change.

Comment on attachment 9010346 [details] [diff] [review] 1492522-MenuBoxObject.patch (v2) Review of attachment 9010346 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, seems to match what m-c has done. ::: suite/browser/nsTypeAheadFind.js @@ +158,5 @@ > element.isContentEditable) > return true; > > // Don't start a find if the focus is on a form element. > + if (isXULElement(element) || Will this work anywhere? m-c only implemented isXULElement in accessible/tests/mochitest/events.js .

Can I just have a review of the landed patch?

This is the suite/ part. Yes, isXULElement() wouldn't have worked, I inlined the function here.

Comment on attachment 9010419 [details] [diff] [review] landed.patch Review of attachment 9010419 [details] [diff] [review]: ----------------------------------------------------------------- Thanks

Comment on attachment 9010428 [details] [diff] [review] 1492522-MenuBoxObject.patch - suite/ part only Can't test right now becuase we are way behind with fixing but look great. r+

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/5fca7138f5f6 Port Bug 1465219: Replace MenuBoxObject with XULElement subclass in suite/. r=frg