Closed Bug 1492704 Opened 6 years ago Closed 6 years ago

Crash in java.lang.NullPointerException: at org.mozilla.geckoview.SessionTextInput.onProvideAutofillVirtualStructure(SessionTextInput.java)

Categories

(GeckoView :: General, defect, P1)

Unspecified
Android
defect

Tracking

(geckoview62 unaffected, firefox62 unaffected, firefox63 unaffected, firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
geckoview62 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

(Keywords: crash)

Crash Data

Attachments

(2 files)

This bug was filed from the Socorro interface and is report bp-846eff60-7103-40f7-b772-4be630180919. ============================================================= Java stack trace: java.lang.NullPointerException: Attempt to invoke virtual method 'int org.mozilla.gecko.util.GeckoBundle.getInt(java.lang.String, int)' on a null object reference at org.mozilla.geckoview.SessionTextInput.onProvideAutofillVirtualStructure(SessionTextInput.java:516) at org.mozilla.geckoview.GeckoView.onProvideAutofillVirtualStructure(GeckoView.java:634) at android.view.View.dispatchProvideStructureForAssistOrAutofill(View.java:8210) at android.view.View.dispatchProvideAutofillStructure(View.java:8202) at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3493) at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510) at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510) at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510) at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510) at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510) at android.app.assist.AssistStructure$WindowNode.<init>(AssistStructure.java:510) at android.app.assist.AssistStructure.<init>(AssistStructure.java:1912) at android.app.ActivityThread.handleRequestAssistContextExtras(ActivityThread.java:3133) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1899) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:164) at android.app.ActivityThread.main(ActivityThread.java:6753) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:482) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
Blocks: 1485810
No longer blocks: 1461961
Update auto-fill info when selecting tabs. Also for auto-fill focus and page events, only handle those events for the foreground tab, so events from background tabs don't inadvertently affect auto-fill for the foreground tab.
Don't update the focused node in the node cache during auto-fill focus events, because we don't necessarily know if the focused node should be in the node cahce (e.g. the focused node could be from another window than the one we're handling currently).
Comment on attachment 9011740 [details] Bug 1492704 - 1. Update auto-fill then selecting tabs; r=petru Petru-Mugurel Lingurar[:petru] has approved the revision.
Attachment #9011740 - Flags: review+
Comment on attachment 9011741 [details] Bug 1492704 - 2. Keep track of the auto-fill focus root node; r=droeh Dylan Roeh (:droeh) has approved the revision.
Attachment #9011741 - Flags: review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf4e7fd47d96 1. Update auto-fill then selecting tabs; r=petru https://hg.mozilla.org/integration/mozilla-inbound/rev/a44a660a1580 2. Don't update node during auto-fill focus event; r=droeh
Jim, do we need to uplift this auto-fill fix to GV 63 Beta or the GV 62 relbranch? The crash volume looks pretty low, though we don't have recent data for GV 62 because Focus 7.0 has temporarily disabled GV's Breakpad crash reporting.
Flags: needinfo?(nchen)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Pretty sure this is specific to Fennec auto-fill (bug 1485810), so we can let it ride the trains on 64.
There ~3000 crashes with this signature after the patch landed. The signature is ranked #0 in nightly top-crashers.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
[Tracking Requested - why for this release]: Crashes number is very high.
Backed out 2 changesets (bug 1492704)by request of jcristau for causing multiple nightly crashes a=backout CLOSED TREE Backout revision https://hg.mozilla.org/mozilla-central/rev/034d18f8ad947f9cc1e730f62ecaf5adfaac50ec Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=be037b5b6327f423a45c50837de07bae9522bd9a :jchen Could you please take a look?
Flags: needinfo?(nchen)
Attachment #9011740 - Attachment description: Bug 1492704 - 1. Update auto-fill then selecting tabs; r?petru → Bug 1492704 - 1. Update auto-fill then selecting tabs; r=petru
Attachment #9011741 - Attachment description: Bug 1492704 - 2. Don't update node during auto-fill focus event; r?droeh → Bug 1492704 - 2. Keep track of the auto-fill focus root node; r?droeh
Flags: needinfo?(nchen)
Attachment #9011741 - Attachment description: Bug 1492704 - 2. Keep track of the auto-fill focus root node; r?droeh → Bug 1492704 - 2. Keep track of the auto-fill focus root node; r=droeh
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b49a74b30e6 1. Update auto-fill then selecting tabs; r=petru https://hg.mozilla.org/integration/autoland/rev/538da6bb518b 2. Keep track of the auto-fill focus root node; r=droeh
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Product: Firefox for Android → GeckoView
Keywords: crash
Target Milestone: Firefox 64 → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: