Closed
Bug 1492777
Opened 6 years ago
Closed 6 years ago
Failing CFR mochitest - browser/components/newtab/test/browser/browser_asrouter_cfr.js
Categories
(Firefox :: New Tab Page, defect, P3)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: andreio, Assigned: andreio)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
|
||
Comment 1•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/89f12a8030bcb8e53018b829c2175b5261bdb7c4
(nobug): Skip failing mochitest browser_asrouter_cfr.js
This will by reverted in Bug 1492777
|
||
Comment 2•6 years ago
|
||
Bug 1485305 landed on inbound when activity stream export bug 1489962 landed on autoland. Seems relevant for the test failure:
[task 2018-09-19T23:17:12.767Z] 23:17:12 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_cfr.js | Uncaught exception - at chrome://browser/content/browser.js:1047 - Error: Must load with a triggering Principal
|
|
||
Comment 3•6 years ago
|
||
I noted in phabricator that using test utils to load uri would have avoided the test failure:
- browser.loadURI("http://example.com");
+ await BrowserTestUtils.loadURI(browser, "http://example.com/");
|
||
Comment 4•6 years ago
|
||
|
|
||
Comment 5•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/ce908fb729e1c82c9df493c469712a9d05e55c80
Fix Bug 1492777 - Failing CFR mochitest browser_asrouter_cfr.js (#4443)
|
|
||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•6 years ago
|
||
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•