Closed
Bug 1492990
Opened 6 years ago
Closed 6 years ago
Make _tabIds map not leak
Categories
(WebExtensions :: General, defect)
WebExtensions
General
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
There are cases when we asynchronously handle tab events, and therefore try to
attach an ID to a tab after it's already been removed. In practice, this will
typically only affect tests, since it requires the tab to be removed
immediately after a related event is dispatched, but in those cases, it causes
a leak, since there's no way for the tab to be removed after the map after
that point.
We should ideally get rid of those weird async hacks, but either way, we
should ensure that we never add a tab to the map after it's already been
removed. This patch does that.
Comment 2•6 years ago
|
||
Comment on attachment 9010780 [details]
Bug 1492990: Make _tabIds map not leak. r=aswan
Andrew Swan [:aswan] has approved the revision.
Attachment #9010780 -
Flags: review+
Assignee | ||
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/807e9ba8d4b8e1d0d362b96aa9878d966b7f8309
Bug 1492990: Make _tabIds map not leak. r=aswan
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 6•6 years ago
|
||
Will you require manual testing on this bug? if yes please add some details onto how it should be validated or set the qe-verify- flag. Thanks!
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•