Closed Bug 1492990 Opened 6 years ago Closed 6 years ago

Make _tabIds map not leak

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

No description provided.
There are cases when we asynchronously handle tab events, and therefore try to attach an ID to a tab after it's already been removed. In practice, this will typically only affect tests, since it requires the tab to be removed immediately after a related event is dispatched, but in those cases, it causes a leak, since there's no way for the tab to be removed after the map after that point. We should ideally get rid of those weird async hacks, but either way, we should ensure that we never add a tab to the map after it's already been removed. This patch does that.
Comment on attachment 9010780 [details] Bug 1492990: Make _tabIds map not leak. r=aswan Andrew Swan [:aswan] has approved the revision.
Attachment #9010780 - Flags: review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Will you require manual testing on this bug? if yes please add some details onto how it should be validated or set the qe-verify- flag. Thanks!
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: