Closed Bug 1493011 Opened 6 years ago Closed 6 years ago

CSS specified-style inspector thinks capitalized property names are invalid (and shows wrong declaration being applied/struckout as a result)

Categories

(DevTools :: Inspector: Rules, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1512634

People

(Reporter: dholbert, Unassigned)

References

Details

(Keywords: regression, Whiteboard: [dt-q])

Attachments

(2 files)

Attached file testcase 1 (deleted) —
STR:
 1. Load attached testcase, and inspect the body (e.g. by right-clicking the text and choosing "Inspect")

ACTUAL RESULTS:
- All declarations that include a capital letter in the property-name (which happen to be the ones that actually apply) are struck-out, as if they were invalid.
- All the prior all-lowercase declarations are displayed as if they were the valid/applied values.


EXPECTED RESULTS:
Exactly the opposite declarations should be struck-out vs. not-struck-out.  The capitalized properties are all valid, so we should be showing that *they* take effect, and that they override the earlier declarations.
This is a somewhat old regression.  There were actually three distinct behaviors (2 behavior changes) that I found in mozregression here.  I'll describe them in terms of the "color" property, the first one listed in the testcase.


BEHAVIOR (A): "color:red" struckout, "Color:green" displayed as valid.  This was the correct behavior.

--> Regression in late May 2016, between Nightly 2016-05-27 and 2016-05-28, with this pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4d63dde701b47b8661ab7990f197b6b60e543839&tochange=ea15028498ed95677844fb7f30be5efcaf8b2621
...(likely bug 1265798) at which point we changed to:

BEHAVIOR (B): incorrect behavior: _all_ declarations shown as struck-out. ("color:red" struck out, which is correct because it's overridden.  "Color:green" also struck out, which is incorrect.)

--> Regression in late Sept 2016, between Nightly 2016-09-22 and 2016-09-23, with this pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f0e6cc6360213ba21fd98c887b55fce5c680df68&tochange=052d4d77cbcae9d168754a62e6f71fd9946743b0
...(likely bug 1265796) at which point we changed to:

BEHAVIOR (C): current, more-incorrect behavior: lowercase declarations (e.g. "color:red") shown as valid, which is incorrect because they're really overridden. Capitalized declarations (e.g. "Color:green") shown as struck out.
Greg would you please see if this regressed due to your changes in Bug 1265798?
Flags: needinfo?(gtatum)
Priority: -- → P2
Whiteboard: [dt-q]
Sorry, I have been NI'ed for a month on this and haven't been able to get to it. I'm going to take myself off of the need info for this. I'm guessing that you are correct that it's from that bug and those changes.
Flags: needinfo?(gtatum)
I think this is now fixed in nightly 66, and probably was fixed by bug 1512634.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: