Closed
Bug 1493250
Opened 6 years ago
Closed 6 years ago
Buttons scroll with weird parallax effect on scrolling
Categories
(Core :: Graphics, defect, P3)
Tracking
()
RESOLVED
DUPLICATE
of bug 1501342
People
(Reporter: miketaylr, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug, )
Details
(Keywords: regression, Whiteboard: [gfx-noted])
Attachments
(2 files)
38196565-7aacc9a8-368c-11e8-871f-bb092eb717c9.gif
In Fennec, or Focus/GeckoView,
1. go to https://www.gty.org/broadcasts/radio/schedule.
2. scroll up and down
ER. sermon button scrolls with its container
AR. sermon button does some wacky Sega Genesis vertical parallax stuff
|
Reporter | |
Comment 1•6 years ago
|
||
(sorry for terrible title)
Summary: Elements → Buttons scroll with weird parallax effect on scrolling
|
||
Comment 2•6 years ago
|
||
Got this to a one day regression range. Several good candidates in that range. Bz, jchen and mstrange. Going to check if I have a working build environment for early 2017 Fennec.
12:45.44 INFO: Got as far as we can go bisecting nightlies...
12:45.44 INFO: Last good revision: f985243bb630b2c78cd57731c8d8ab191aa09527 (2017-02-02)
12:45.44 INFO: First bad revision: bf15d4078c2a6db7df37ab466d28a1e075c9eb4d (2017-02-03)
12:45.44 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f985243bb630b2c78cd57731c8d8ab191aa09527&tochange=bf15d4078c2a6db7df37ab466d28a1e075c9eb4d
|
||
Comment 3•6 years ago
|
||
I need to dig them up again, but I remember we had at least one or two other bugs with that sort of unintended parallax effect.
|
|
||
Comment 4•6 years ago
|
||
The first bad revision is:
changeset: 332056:5746c9b9db68
user: Markus Stange <mstange@themasta.com>
date: Fri Jan 27 17:38:55 2017 +0100
summary: Bug 1298218 - Add a workaround for root scroll frame container layer scrolling. r=tnikkel
Blocks: 1298218
Flags: needinfo?(mstange)
|
||
Updated•6 years ago
|
Keywords: regression
|
||
Comment 5•6 years ago
|
||
Over to GFX for triage.
Component: GeckoView → Graphics
Product: Firefox for Android → Core
Version: Firefox 56 → 56 Branch
|
||
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: [gfx-noted]
|
||
Comment 6•6 years ago
|
||
Botond, do you think you could take a look at this one?
Flags: needinfo?(mstange) → needinfo?(botond)
|
||
Comment 7•6 years ago
|
||
This triggers the following assertion failure in debug mode, making it an APZLayout issue:
Assertion failure: false (Two layers that scroll together have different ancestor transforms), at /home/botond/dev/mozilla/central/gfx/layers/apz/src/APZCTreeManager.cpp:1122
Blocks: APZLayout
Flags: needinfo?(botond)
|
|
||
Updated•6 years ago
|
|
|
||
Comment 8•6 years ago
|
||
*And*, for good measure, the assertion in bug 1427792 too.
Depends on: 1427792
|
|
||
Comment 9•6 years ago
|
||
Attached is a layer dump. Besides being suspiciously long, there are a number of places where the same scroll id occurs at three different levels in the layer tree (a layer, a child layer, and a grandchild layer); that's all kinds of wrong.
|
|
||
Comment 10•6 years ago
|
||
We are planning to make some changes to FrameLayerBuilder in bug 1501342 which should hopefully eliminate a category of these bugs. Let's see if that fixes this too.
Depends on: 1501342
|
|
||
Comment 11•6 years ago
|
||
This is indeed fixed by the patch in bug 1501342.
|
|
||
Comment 12•6 years ago
|
||
Verified fixed in today's nightly.
|
|
||
Comment 13•6 years ago
|
||
Setting flags as per bug 1501342.
You need to log in
before you can comment on or make changes to this bug.
Description
•