Closed Bug 1493698 Opened 6 years ago Closed 6 years ago

[remote-dbg-next] Add a helper to localize outside of components

Categories

(DevTools :: about:debugging, enhancement, P1)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1493698 - Add l10n localization helper for new about:debugging;r=daisuke
(deleted), text/x-phabricator-request
Details 
Right now all our localization is based on reusing fluent-react Localized and withLocalization helpers. However this means non-component files have no mean of localizing any string. 

A proposal to address this is to expose withLocalization::getString on a l10n.js helper that could be used transparently by actions, reducers, modules etc...

Technically we could pass getString from the topmost component to this helper, but maybe there is a cleaner way to do this.
Blocks: remote-debugging-ng-m2
No longer blocks: remote-debugging-ng
Priority: P3 → P2
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09f652c90688
Add l10n localization helper for new about:debugging;r=daisuke
https://hg.mozilla.org/mozilla-central/rev/09f652c90688
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: