Closed
Bug 1494000
Opened 6 years ago
Closed 6 years ago
Use Element::GetFrame in XULMenuElement and XULPopupElement
Categories
(Core :: XUL, enhancement, P5)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → enndeakin
Attachment #9012189 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P5
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9012189 [details] [diff] [review]
Use Element::GetFrame in XULMenuElement and XULPopupElement
>Bug 1494000, use Element::GetFrame in XULMenuElement and XULPopupElement, r=bz
GetPrimaryFrame, not GetFrame.
> XULPopupElement::GetOuterScreenRect()
This should get a MOZ_CAN_RUN_SCRIPT annotation.
> XULPopupElement::GetAlignmentPosition()
Same.
> XULPopupElement::AlignmentOffset()
Same.
> XULPopupElement::SetConstraintRect
Same.
r=me with those nits fixed. Thank you!
Attachment #9012189 -
Flags: review?(bzbarsky) → review+
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a22c1051967
use Element::GetFrame in XULMenuElement and XULPopupElement, r=bz
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•