Closed
Bug 149417
Opened 22 years ago
Closed 22 years ago
Treat US-ASCII as ISO-8859-1 (Meta chaset tag)
Categories
(Core :: Internationalization, defect, P1)
Tracking
()
VERIFIED
FIXED
People
(Reporter: momoi, Assigned: shanjian)
References
Details
(Keywords: dataloss, intl, topembed, Whiteboard: [adt2])
Attachments
(1 file)
(deleted),
patch
|
ftang
:
review+
alecf
:
superreview+
chofmann
:
approval+
|
Details | Diff | Splinter Review |
** Observed with 2002-06-04 Win32 1.0 branch build **
There are a number of web pages which mistakenly label IS-8859-1 pages as
US-ASCII. While this is an evangelism issue, we can also alleviate this problem
by assuming that US-ASCI label is equivalent to ISO-8859-1.
Assigning this to Shanjian who already worked on a similar NS-internal issues.
So far neither shanjian nor I believe that there will be bad side effects of doing
this and this will help resolve a number of evangelism issues in Latin Amartican
sites.
Comment 1•22 years ago
|
||
Can you please give an example page?
pi
Comment 2•22 years ago
|
||
Marking topembed based in the AOLMAIL sites. Kat, let us know if you think this
one should be nsbeta1 also. Probably late in the game for this.
Keywords: topembed
Reporter | ||
Comment 3•22 years ago
|
||
jaime, this is topembed for us. I would also like to nominate this
for nsbeta1. A lot of Latin American sites are affected by this
problem.
Keywords: nsbeta1
Assignee | ||
Comment 4•22 years ago
|
||
Comment 6•22 years ago
|
||
Should we change the charsetalias.property instead?
Comment 7•22 years ago
|
||
nsbeta1+
IF the site have this mislabel. we will lost data when we submit the form
Assignee | ||
Comment 8•22 years ago
|
||
frank,
I worried about 2 side-effect if using charset alias.
1, we don't want to affect unicode to ascii, only ascii to unicode.
2, We still want to mark the web page as us-ascii encoding even we treat it as
iso-8859-1. Otherwise, for a page that is really strict ascii, and it is labeled
so, we shouldn't mark it as iso-8859-1.
Comment 9•22 years ago
|
||
if you don't treat them as ISO-8859-1 then what will happen when you sutmit a
form? the ISO-8859-1 characters will be lost in the form submission.
Assignee | ||
Comment 10•22 years ago
|
||
Yes, that's a strong argument. But if we do that, we may face complain about
ascii document originated from our browser.
Assignee | ||
Comment 11•22 years ago
|
||
Frank, a second thought. My patch should not have any problem in posting. If a
char could not be encoded in us-ascii, NCR will be used and result should be
fine. If we use alias, and if the charset is marked correctly as us-ascii, then
we will have problem in post because high ascii will be encoded in latin1
instead of NCR.
(I tested this on my build, the hight ascii post works fine when charset is
us-ascii.)
Please r= and I will drive this in.
Comment 12•22 years ago
|
||
Comment on attachment 88976 [details] [diff] [review]
patch
r=ftang
Attachment #88976 -
Flags: review+
Assignee | ||
Comment 13•22 years ago
|
||
blizzard, could you sr?
Comment 14•22 years ago
|
||
shanjian: mgalli@netscape.com said it is important for us to fix this asap.
Please make this a high priority now.
Priority: -- → P1
Comment 15•22 years ago
|
||
Comment on attachment 88976 [details] [diff] [review]
patch
sr=alecf
Attachment #88976 -
Flags: superreview+
Comment 16•22 years ago
|
||
shanjian, can we land this in asap ?
Assignee | ||
Comment 17•22 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 18•22 years ago
|
||
Kat: is there some page labled as US-ASCII that I can use for verification? thanks!
Reporter | ||
Comment 19•22 years ago
|
||
Sent ylong the info on sites with this problem.
After testing with them, please write down some URLs
in this bug also.
Comment 20•22 years ago
|
||
All right(TM)!
=============
We tested with Kat Momoi, Doron and me with the AOLMAIL.aol.com.br looks super
great! this fixes the cases with Yahoo Brasil, AOLMAIL in Brazil, Mexico and
Argentina AOLMAIL as well. Additionally (I learned here) this prevents the
dataloss :) super thanks! Shanjian, Frank and Kat Momoi and all the others
involved.
Comment 21•22 years ago
|
||
I also verified it on Argentina mail site by forword a message without a receiver.
Mark as veirified.
I think we should check this into branch as well.
Comment 23•22 years ago
|
||
Do this patch also fix bug 77741 ?
Comment 24•22 years ago
|
||
please consider taking this for the build for bug 168047. This is a very safe
fix. This fix has been land and verified on trunk already.
Blocks: blackbird
Keywords: mozilla1.0.2
Comment 25•22 years ago
|
||
adt1.0.2+. Discussed in Blackbird team meeting. Please check in by close of
business today.
Comment 26•22 years ago
|
||
Comment on attachment 88976 [details] [diff] [review]
patch
a=chofmann for 1.0.2
Attachment #88976 -
Flags: approval+
Assignee | ||
Comment 27•22 years ago
|
||
fix checked into branch.
Comment 28•22 years ago
|
||
Verified fixed in 10-21 branch build.
Comment 29•22 years ago
|
||
Marking as verified1.0.2 per Comment #28 From Yuying Long.
Keywords: mozilla1.0.2 → verified1.0.2
You need to log in
before you can comment on or make changes to this bug.
Description
•