Open
Bug 1494208
Opened 6 years ago
Updated 2 years ago
Write better tests for screenshot commands
Categories
(Testing :: Marionette Client and Harness, enhancement, P3)
Testing
Marionette Client and Harness
Tracking
(Not tracked)
NEW
People
(Reporter: ato, Unassigned)
References
(Blocks 1 open bug)
Details
The existing tests for Take Screenshot and Take Element Screenshot
commands are fairly basic. We could borrow some tests from
https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_screenshot.py
to improve the situation.
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1431148 contains some
useful test utilities that is needed to start this work.
Reporter | ||
Comment 2•6 years ago
|
||
Jim, can you confirm for me what IEDriver’s behaviour is for the
Take Screenshot command? Firefox will currently use the bounding
client rect of the document element, but I would’ve expected this
command to include the full viewport, even if the document itself
is smaller?
Flags: needinfo?(james.h.evans.jr)
Reporter | ||
Comment 3•6 years ago
|
||
I spoke to jimevans on IRC and he confirmed my suspicion, that we
use the viewport’s dimensions and do not clamp on the document
element’s bounding box.
This seems to also be confirmed with the patch in
https://bugzilla.mozilla.org/show_bug.cgi?id=1385706 that I just
reviewed, which will fix this underlying problem for us.
Flags: needinfo?(james.h.evans.jr)
Reporter | ||
Updated•6 years ago
|
Assignee: ato → nobody
Priority: P2 → P3
Updated•2 years ago
|
Severity: normal → S3
Updated•2 years ago
|
Product: Testing → Remote Protocol
Updated•2 years ago
|
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•