If a theme were created with an excessively long description, the link at the bottom of the Themes pref-panel would no longer be visible. This results from the "Get New Themes" link being included in the text area used for display of the description. Note that, when a theme has an excessively long description, some of the description may no longer be visible either.

This is a modified version of chrome.rdf with the description of the classic theme repeated numerous times, causing the "Get New Themes" link to be pushed off-screen when the "Classic" theme is highlighted. To use, close Mozilla, copy this file over chrome.rdf in the Mozilla\chrome directory, reopen Mozilla, open the prefs dialog, select Appearance|Themes, and highlight "Classic". Expected Result: "Get New Themes" link remains in a fixed position, maintaining UI consistency. Actual Result: "Get New Themes" link is pushed down by the long description text, to the point that it is no longer visible to the user.

Bug 149543 has been created to cover the related issue of part of the description becoming non-visible as well. However, fixing this bug only requires moving the "Get New Themes" link out of the description text area, while fixing that one requires adding some provision for extending that area beyond the size of the prefs panel.

Confirming on 1.0RC3, Windows 98.

This is a dupe (possible twice submitted) and this bug belongs to skinability (since the pref panel is from there) I can's search at the moment because the bug databse is laggy.

--> Skinability

*** Bug 160974 has been marked as a duplicate of this bug. ***

Makes the description scrollable when it does not fit in the dialog (with my current default Win settings this happens as soon as there are more than three description lines).

Comment on attachment 140424 [details] [diff] [review] patch, show scrollbar for too long descriptions. Requesting r= from Neil. (BTW, this will also fix bug 149453, of course, which is almost - if not really - a duplicate).

Comment on attachment 140424 [details] [diff] [review] patch, show scrollbar for too long descriptions. There are two things that I don't like with this solution (although that doesn't mean there's a better solution) - the first is that the margin is on the label, not the vbox, so that the scrollbar doesn't line up with the other items in the panel, the second is that because the flex normally pushes the link to the bottom of the panel you don't need a separator, or at least not so large a separator.

This patch replaces the separator below by a class="thin" one; the gap between is now smaller and now four lines do still fit without a scrollbar appearing. I added a right margin of 5px to the vbox so the scrollbar lines up with the items below and above. This does work across themes, I also tested Orbit and LCARStrek. Margins of the other elements are partly taken from formatting.css, e.g. .description and .inset (for the preview image) get 5px from there for both themes in lxr and for both mac/win (I think unix uses win). So those 5 px are pretty safe to be correct.

Alternatively use class="inset" which gets the margin from the current theme and should be perfectly safe this way. It also changes the appearance of the description to look "deeper", which looks especially nice if there is a scrollbar (what should happen rarely, though). Not sure if this is desired. I'll attach screenshots.

Comment on attachment 140505 [details] [diff] [review] improved patch using class="inset" Setting r= request for Neil; however, please consider both current patches because I'm not sure if that inset is ok for you...

Comment on attachment 140505 [details] [diff] [review] improved patch using class="inset" Hey, that looks great. Do we still need a separator with class="inset"?

No, we don't. This patch has the separator removed and it still looks good (distance between is a tiny bit smaller, but still fine).

Comment on attachment 140552 [details] [diff] [review] patch with inset and no separator Again requesting r= from Neil.

Comment on attachment 140552 [details] [diff] [review] patch with inset and no separator Requesting sr= from alecf.

Comment on attachment 140552 [details] [diff] [review] patch with inset and no separator sr=alecf

Checking in xpfe/components/prefwindow/resources/content/pref-themes.xul; /cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-themes.xul,v <-- pref-themes.xul new revision: 1.51; previous revision: 1.50 done

verified with current cvs build