Closed Bug 1494617 Opened 6 years ago Closed 6 years ago

"desiredCapabilities" and "requiredCapabilities" are not evaluated since using Serde

Categories

(Testing :: geckodriver, defect, P1)

Product:
Testing
Component:
geckodriver
Version:
63 Branch
Type:
defect

Tracking

(firefox-esr60 unaffected, firefox62 unaffected, firefox63 fixed, firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(
URL
)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1494617 - [geckodriver] Fix evaluation of "desiredCapabilities" and "requiredCapabilities". r?ato
(deleted), text/x-phabricator-request
ato
: review+
Details
This is another regression from my Serde refactoring. So we no longer evaluate both capability types. Instead we check for "desired", and "required".
The refactoring of the webdriver crate to use Serde (bug 1396821) caused this regression. By instructing Serde to correctly rename both properties fixes it.
Comment on attachment 9012567 [details] Bug 1494617 - [geckodriver] Fix evaluation of "desiredCapabilities" and "requiredCapabilities". r?ato Andreas Tolfsen ❲:ato❳ has approved the revision.
Attachment #9012567 - Flags: review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc7d1d5fd6f6 [geckodriver] Fix evaluation of "desiredCapabilities" and "requiredCapabilities". r=ato
https://hg.mozilla.org/mozilla-central/rev/fc7d1d5fd6f6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
This test-only patch fixes a regression in geckodriver. Please uplift to beta.
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: