Closed
Bug 1494685
Opened 6 years ago
Closed 6 years ago
Text on payun-payun parallax page disappears when it isn't fully in the viewport
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox63 | --- | unaffected |
| firefox64 | --- | fixed |
| firefox65 | --- | fixed |
People
(Reporter: kats, Assigned: emilio)
References
Details
(Keywords: correctness, regression, Whiteboard: [gfx-noted][wptsync upstream])
Attachments
(4 files)
bug.png
Go to https://belen-albeza.github.io/scroll-demos/parallax.html and start scrolling down. Observe the text-shadow on the "Payun-payun" header. As soon as the bounding box for that element hits the edge of the viewport the text shadow disappears.
I can reproduce on macOS and Windows. Happens even with APZ off.
|
Reporter | |
Comment 1•6 years ago
|
||
Also related: the airplane that scrolls up from the bottom also disappears as soon as it encounters the edge of the viewport instead of getting clipped properly.
|
||
Updated•6 years ago
|
Blocks: 1415272, stage-wr-trains
status-firefox64:
--- → affected
Keywords: correctness
OS: Unspecified → All
Priority: -- → P3
|
||
Comment 2•6 years ago
|
||
This sounds similar to the problem reported in this comment on github: https://github.com/servo/webrender/issues/3087#issuecomment-423595274
It seems that whenever 3d transformed elements are not visible in their entirety, we paint the wrong parts of the contents.
|
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Priority: P3 → P2
|
||
Comment 3•6 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #1)
> Also related: the airplane that scrolls up from the bottom also disappears
> as soon as it encounters the edge of the viewport instead of getting clipped
> properly.
As of today, the airplane disappears, but some part of it is drawn in the tab-bar.
Please see the screenshot attached
|
|
||
Comment 4•6 years ago
|
||
see at the top of the tab-bar
|
Assignee | |
Comment 5•6 years ago
|
||
The airplane looks fine now, it's only text what disappears.
|
|
Assignee | |
Comment 6•6 years ago
|
||
AFAICS it's only text (shadows remain there correctly) and it's not only the header (other text like the "(Psttt… that browser is Firefox.)" also disappears.
Summary: Text shadow on header element payun-payun parallax page disappears when element isn't fully in the viewport → Text on payun-payun parallax page disappears when it isn't fully in the viewport
|
|
Assignee | |
Comment 8•6 years ago
|
||
|
|
Assignee | |
Comment 9•6 years ago
|
||
Probably not the most reliable test to catch this (as it depends on
the font and such) but still fails here and I'd like WPT to have a test-case
for this. I'm looking into adding a WR test-case ATM, though fighting with
it way too much.
|
|
Assignee | |
Comment 10•6 years ago
|
||
Still got to find a more reliable test-case for WR.
|
||
Comment 11•6 years ago
|
||
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/d44ae1668a70
Add a reftest. r=kats
|
|
||
Comment 12•6 years ago
|
||
Backout by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c25a0b6d269
Backed out changeset d44ae1668a70 as per emilio's request.
|
||
Comment 13•6 years ago
|
||
Please note that a wpt linting failure was present on your push:
https://treeherder.mozilla.org/logviewer.html#?job_id=204981680&repo=autoland&lineNumber=258
|
|
Assignee | |
Comment 14•6 years ago
|
||
That is a linter bug, about:blank is a perfectly valid reference.
Flags: needinfo?(james)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13487 for changes under testing/web-platform/tests
Whiteboard: [gfx-noted] → [gfx-noted][wptsync upstream]
|
|
||
Updated•6 years ago
|
Depends on: 1498376
See Also: → https://github.com/servo/webrender/pull/3187
|
||
Comment 16•6 years ago
|
||
Hmm, this was supposed to be fixed by https://github.com/web-platform-tests/wpt/pull/9421; I'll check what's going on.
|
|
||
Comment 17•6 years ago
|
||
Flags: needinfo?(james)
Upstream PR was closed without merging
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13487
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/440625751?utm_source=github_status&utm_medium=notification)
Whiteboard: [gfx-noted][wptsync upstream] → [gfx-noted][wptsync upstream error]
|
|
||
Comment 20•6 years ago
|
||
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d5c8e9ca5a3
Add a reftest. r=kats
Whiteboard: [gfx-noted][wptsync upstream error] → [gfx-noted][wptsync upstream]
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13487
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/448101101?utm_source=github_status&utm_medium=notification)
Whiteboard: [gfx-noted][wptsync upstream] → [gfx-noted][wptsync upstream error]
Whiteboard: [gfx-noted][wptsync upstream error] → [gfx-noted][wptsync upstream]
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 23•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Upstream PR merged
|
||
Comment 25•6 years ago
|
||
Is this something we should consider backporting to Beta for the experiments running there or can this just ride the 65 train?
status-firefox63:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Flags: needinfo?(emilio)
Flags: in-testsuite+
Keywords: regression
|
|
Assignee | |
Comment 26•6 years ago
|
||
I think the fix landed on beta, given https://github.com/servo/webrender/pull/3187 landed 20 days ago.
Flags: needinfo?(emilio)
|
|
||
Comment 27•6 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•