Closed
Bug 1495717
Opened 6 years ago
Closed 6 years ago
Provide user friendly information about a flex item's sizing
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/x-phabricator-request
|
Details |
In bug 1478397, we will land the very first version of the flex item sizing sidebar.
For now, it will contain a flat list of properties that relate to where a flex item got its size.
Now, in this second bug, we will transform this list into something that contains more information, and more user-friendly information. The goal being to explain in a straightforward way how an item really got its size.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
QA Contact: gl
Assignee | ||
Comment 1•6 years ago
|
||
WIP patch just to show the progress made so far.
I need to wait for the blocker bug to land first and then I'll rebase this.
I still need to polish this patch up and write tests.
Updated•6 years ago
|
Assignee: pbrosset → nobody
Status: ASSIGNED → NEW
Updated•6 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Still a lot of work to do here, but I'd like to try to land this in 64 anyway. It's not a big deal because we plan on keeping the feature hidden behind a flag for now.
The reason is that there is some actor code that landed in 64 with bug 1478397, and I'm changing it in this bug. So I'd rather have those changes in 64 too and avoid messy backwards compat code.
So I'll polish up this patch and fix the obvious issues, but won't wait until it's 100% robust before landing. We'll do this through follow-upo bugs and will only turn the flag ON when things are stable anyway.
Assignee | ||
Comment 3•6 years ago
|
||
MozReview-Commit-ID: 3cSeShKP6TE
Assignee | ||
Comment 4•6 years ago
|
||
MozReview-Commit-ID: 3cSeShKP6TE
Updated•6 years ago
|
Attachment #9015900 -
Attachment is obsolete: true
Updated•6 years ago
|
Blocks: dt-flexbox
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f5483bd51ed
More user-friendly Flex item sizing information; r=gl
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•