Closed
Bug 1495879
Opened 6 years ago
Closed 6 years ago
write real wasm support for aarch64 windows
Categories
(Core :: JavaScript: WebAssembly, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: froydnj, Assigned: away)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
We're going to want this at some point. This probably relies on at least bug 1484835.
|
||
Updated•6 years ago
|
Component: JavaScript Engine: JIT → Javascript: Web Assembly
This turned out to be easier than I expected: the #define forest is less daunting after I realized there's only a couple sections that need updating. I should have just written this from the start and saved myself the disable-patch.
Unless, of course, I'm missing something about this picture.
Re comment 0, the jit unwinding in bug 1484835 seems orthogonal to me. It's a problem for wasm and plain-old-js equally, as far as I can tell.
Assignee: nobody → dmajor
Attachment #9023998 -
Flags: review?(luke)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9023998 [details] [diff] [review]
wasm-aarch64
Review of attachment 9023998 [details] [diff] [review]:
-----------------------------------------------------------------
Nice! (FWIW, the forest got pruned recently (bug 1495149) :)
Attachment #9023998 -
Flags: review?(luke) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/959d83958227
Fix register macros and re-enable wasm on aarch64-windows. r=luke
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•