Closed
Bug 1495898
Opened 6 years ago
Closed 6 years ago
JavaScript error: resource://gre/modules/ActorManagerChild.jsm, line 72: NS_ERROR_FILE_NOT_FOUND:
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird63 wontfix, thunderbird64 fixed, thunderbird65 fixed)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1485649 +++
https://taskcluster-artifacts.net/AGyzGCxlT_uSUSpm3G4j0g/0/public/logs/live_backing.log
shows this error
JavaScript error: resource://gre/modules/ActorManagerChild.jsm, line 72: NS_ERROR_FILE_NOT_FOUND:
542 times.
Interested, Magnus?
Flags: needinfo?(mkmelin+mozilla)
This is because the modules provided by toolkit are not packaged.
@RESPATH@/actors/*
Assignee | ||
Comment 2•6 years ago
|
||
OK, let's see what that does. Thanks Alta88!
Assignee: nobody → jorgk
Flags: needinfo?(mkmelin+mozilla)
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 9020084 [details] [diff] [review]
1495898-actors.patch
I guess that's broken on the beta, too.
Attachment #9020084 -
Flags: approval-comm-beta+
Assignee | ||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3a32487f3a23
add @RESPATH@/actors/* to package manifest (analysis by Alta88). rs=bustage-fix
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•6 years ago
|
||
Thanks. I'll check the fix on trunk and then it goes to TB 64 beta.
Assignee | ||
Comment 7•6 years ago
|
||
Total success, error gone - \o/
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
status-thunderbird63:
--- → wontfix
status-thunderbird64:
--- → fixed
status-thunderbird65:
--- → fixed
Weren't there a lot of webextension tests that were turned off? They should be turned on if we're going to be serious about implementing it properly..
Assignee | ||
Comment 10•6 years ago
|
||
They've all been turned on again here: https://hg.mozilla.org/mozilla-central/rev/163742dd3235
Comment 12•6 years ago
|
||
Test management has been really excellent, I just want to point out that web extension tests also need to be reviewed and some that seem to potentially apply to Tb have been turned off:
+skip-if = appname == "thunderbird" || os == "android"
[test_ext_cookieBehaviors.js]
..
+fail-if = appname == "thunderbird"
skip-if = os == "android"
[test_ext_downloads_misc.js]
..
+fail-if = appname == "thunderbird"
[test_ext_extension.js]
..
+skip-if = appname == "thunderbird"
[test_ext_onmessage_removelistener.js]
..
+skip-if = appname == "thunderbird"
[test_ext_webRequest_startup.js]
..
+skip-if = appname == "thunderbird"
[test_ext_xhr_capabilities.js]
Some Fx web extensions should Just Work in Tb at this point. For example, script injection doesn't seem to work and it may be because the messageManager object attached to messagepane <browser> doesn't have a processMessageManager handler, from what I've debugged so far in uBlock, which finally semi works for http urls given this patch.
(I know it's separate bugs, I'm just sayin..)
Assignee | ||
Comment 13•6 years ago
|
||
(In reply to alta88 from comment #12)
> (I know it's separate bugs, I'm just sayin..)
Thanks for you help in this bug, especially since it also fixed an urgent print preview problem (see bug 1502219).
I'd appreciate it very much if you could file a new bug for the WE stuff and CC me and geoff@thunderbird.net.
You need to log in
before you can comment on or make changes to this bug.
Description
•