Closed Bug 1496062 Opened 6 years ago Closed 5 years ago

Remove add-on type specific search labels

Categories

(Toolkit :: Add-ons Manager, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mstriemer, Assigned: gaurijove, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

If you use the AMO search bar from about:addons on the extensions page, you should only see extensions. Similarly for themes, you should get themes. For the other pages you should get any type of add-on from AMO.

Do we still want this?

Assignee: mstriemer → nobody
Flags: needinfo?(jorge)
Priority: P3 → P5

I think we can drop this for now. However, the label next to the search bar changes depending on the panel you have selected (Find more extensions, Find more themes). We should at least keep the label static as "Find more add-ons" for all panels.

Flags: needinfo?(jorge)

The heading search label is set [1] based on the type of the page, but it should always use the "default" string now. This should be able to move from the .js file to the .html file now [2].

[1] https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/toolkit/mozapps/extensions/content/aboutaddons.js#1347-1356
[2] https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/toolkit/mozapps/extensions/content/aboutaddons.html#68

No longer blocks: 1489296
Mentor: mstriemer
Keywords: good-first-bug
Summary: Filter AMO search results based on about:addons page → Remove add-on type specific search labels

May I submit a patch for this?

Assignee: nobody → gaurijove
Status: NEW → ASSIGNED
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0863829d7f89 Remove add-on type specific search labels. r=mstriemer,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: