Closed
Bug 1496207
Opened 6 years ago
Closed 6 years ago
Allow to request uplift of multiple patches at once by adding checkboxes for other patches
Categories
(bugzilla.mozilla.org :: Extensions, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kohei, Assigned: kohei)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
See :MattN’s feedback on Twitter: https://twitter.com/mnoorenberghe/status/1047571006670299136
Well, the best UX might be an ability to change multiple attachments at once (which can be done if you use the API) but we don’t have such a UI yet.
The request from the Release Management team is making custom form filling mandatory, but can we make it optional and fallback to the regular comment form at least when there is already a request on the same bug? :Sylvestre, what do you think?
Flags: needinfo?(sledru)
Comment 1•6 years ago
|
||
I don't know if we can be more ambitious:
In a perfect world, when selecting mozilla-approva-beta, under the form, in case there are several attachments, I would love to see something like
"Do you want to also uplift this patch ?" with a checkbox next to it. This for every patch
If not possible, we could add a line "All other patches should be uplifted?" Yes/no
Flags: needinfo?(sledru)
Assignee | ||
Comment 2•6 years ago
|
||
Let’s try that out.
Assignee | ||
Updated•6 years ago
|
Severity: normal → enhancement
Status: NEW → ASSIGNED
Summary: Custom flag approval request form: Figure out how to handle multiple uplifts on the same bug → Allow to request uplift of multiple patches at once by adding checkboxes for other patches
Assignee | ||
Comment 3•6 years ago
|
||
WIP: https://github.com/kyoshino/bmo/compare/bug-1496207-tfc-multi-uplift
This shows other patches with a checkbox for each, and uses the API to set approval flag(s) to these selected patches. However the relevant API is broken, which will be fixed in my another PR.
Depends on: 1209148
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
Merged to master.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Extensions: FlagTypeComment → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•