Closed
Bug 1496542
Opened 6 years ago
Closed 2 years ago
Fix reftest failures from rounding/off-by-one on WebRender
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: kats, Unassigned)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [gfx-noted])
These tests are failing with WebRender with what seems to be an off-by-one/rounding problem.
./layout/reftests/writing-mode/reftest.list:
== 1193519-sideways-lr-3.html 1193519-sideways-lr-3-ref.html
== 1193519-sideways-lr-4.html 1193519-sideways-lr-4-ref.html
./layout/reftests/svg/smil/style/reftest.list:
== anim-css-strokewidth-1-from-by-pct-pct.svg anim-css-strokewidth-1-ref.svg
== anim-css-strokewidth-1-from-to-pct-pct.svg anim-css-strokewidth-1-ref.svg
== anim-css-strokewidth-1-to-pct-pct.svg anim-css-strokewidth-1-ref.svg
./layout/reftests/bugs/reftest.list:
== 1291528.html 1291528-ref.html
./layout/reftests/svg/svg-integration/clip-path/reftest.list:
== clip-path-polygon-013.html clip-path-stripes-003-ref.html
https://treeherder.mozilla.org/#/jobs?repo=try&bugfiler=&group_state=expanded&revision=4aee7c413aa978c5cd41f6065c654d55025b70b0
Updated•6 years ago
|
QA Contact: mreavy
Updated•6 years ago
|
QA Contact: mreavy
Comment 1•6 years ago
|
||
There are also a couple form-related reftests that are fuzzy in a similar way. I'll look into these as I recently looked at bug 1444185 and such.
A new one from bug 1495153:
./layout/reftests/forms/input/file/reftest.list:
== dynamic-max-width.html dynamic-max-width-ref.html
Which actually used to pass before my work in bug 1444185, and fails across the board. So I still think that the way we do snapping of fallback is not quite right.
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Updated•6 years ago
|
Priority: -- → P2
Updated•6 years ago
|
Blocks: stage-wr-trains
Comment 2•6 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
> A new one from bug 1495153:
>
> ./layout/reftests/forms/input/file/reftest.list:
> == dynamic-max-width.html dynamic-max-width-ref.html
FYI, in bug 1500530 I'm making the anonymous <label> have display:inline-block
(instead of the default display:inline). This made it pass on WebRender(OSX)
but not on other platforms. So I'm tagging it random-if(webrender) for now.
Reporter | ||
Comment 3•6 years ago
|
||
Could you tag it as fails-if(webrender&&!cocoaWidget) instead?
Comment 4•6 years ago
|
||
Sure, no problem. I repeated the test a few more times and seems to be a stable pass.
Updated•6 years ago
|
Priority: P2 → P3
Updated•6 years ago
|
Comment 5•6 years ago
|
||
I'm not actively looking into this, and this is not blocking the MVP anyhow so...
Assignee: emilio → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(emilio)
Comment 6•2 years ago
|
||
These tests work on WR now.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•