Closed
Bug 1496552
Opened 6 years ago
Closed 6 years ago
Prio-encoded Telemetry should use build ID for its batch ID
Categories
(Toolkit :: Telemetry, enhancement)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: rhelmer, Assigned: rhelmer)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Per https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/third_party/prio/include/mprio.h#80-84 we need to share the batch ID between the client and server.
When I added Prio-encoding to Telemetry, I had thought `Policy.now()` https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/toolkit/components/telemetry/pings/TelemetrySession.jsm#1985 was the current date string, but looking now it's a datestring https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/toolkit/components/telemetry/pings/TelemetrySession.jsm#121
However after discussing w/ amiyaguchi, I think for the purposes of the pilot project it'd be simplest on the server-side to just use the build ID here.
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by rhelmer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e1d1b6a529e
Use build ID as the batchID for prio-encoded telemetry r=chutten
Comment 3•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•