Remove VPATH
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: mshal, Assigned: mshal)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Having a full VPATH for the srcdir sometimes causes make to grab the
wrong prerequisite for a rule, in particular if we have a file in the
srcdir and also generate a file of the same name in the objdir. We don't
really need VPATH anymore though, since most of the information comes
from mozbuild, where we can explicitly list the path to the srcdir or
objdir as necessary.
There are some spots where a more targetted vpath directive makes sense.
First is for the RCFILE, since this is either a file we generate in the
objdir (module.rc), or a file in a PassthruVariable from moz.build in
the srcdir. Adding a vpath here to look in the srcdir for the
PassthruVariable version seems reasonable, though we could also consider
making RCFILE a Path object instead.
The other targetted vpath is needed for pattern rules with directory
components, since make separates the directory from the stem and
prepends it to the path for some reason, which results in a non-sensical
path. See the comment in media/libvpx/Makefile.in for details.
Updated•5 years ago
|
Comment 6•5 years ago
|
||
bugherder |
Description
•