Closed Bug 1496807 Opened 6 years ago Closed 6 years ago

Update strings (de Pocket-related and others) for 63

Categories

(Firefox :: New Tab Page, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Iteration:
64.3 - Oct 12
Tracking Status
firefox63 + verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(4 files)

[Tracking Requested - why for this release]: Strings were last updated in 63 over 5 weeks ago. In particular newly added pocket related strings are shown in English in 63b12 (see attachment)
Ed, did you ask for tracking for 63 release because you intend to uplift a patch in our last beta this week? Thanks
Flags: needinfo?(edilee)
Yes, we'll want to uplift strings to 63.
Flags: needinfo?(edilee)
Assignee: nobody → edilee
Status: NEW → ASSIGNED
(In reply to Ed Lee :Mardak (PTO Sep 15 - Oct 7) from comment #4) > Created attachment 9015308 [details] > Bug 1496807 - Update strings (de Pocket-related and others) for 63 Note for uplift: this doesn't have an actual l10n impact, .properties files uplifted are outside of localizable paths, and are exposed for localization only via mozilla-central.
Comment on attachment 9015308 [details] Bug 1496807 - Update strings (de Pocket-related and others) for 63 Attachment 9015308 [details] for mozilla-beta is r+flod in phabricator [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1483655 User impact if declined: German users see english text (and other locales will have outdated / english strings). See attachment 9015309 [details] for comparison Is this code covered by automated tests?: No Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Just updating strings String changes made/needed: Yes, these are the translated strings and don't impact l10n as per comment 6
Attachment #9015308 - Flags: approval-mozilla-beta?
Comment on attachment 9015308 [details] Bug 1496807 - Update strings (de Pocket-related and others) for 63 Strings update with no l10n impact, uplift approved for 63 beta 14, thanks.
Attachment #9015308 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
I have verified that this issue is no longer reproducible with the latest Firefox Beta (63.0b14 Build ID - 20181011200118) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the Pocket strings are correctly displayed and translated according to the used locale build.
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: