Closed Bug 1496890 Opened 6 years ago Closed 6 years ago

action hook tasks should show who triggered them

Categories

(Firefox Build System :: Task Configuration, task, P5)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mozilla, Assigned: biboswan98)

References

Details

Attachments

(1 file)

Bug 1496890 - include client calling triggerHook in action description
(deleted), text/x-phabricator-request
Details
Looking at https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=54cb6a2f028b033ef567f00af2f82f5fb97ab437&searchStr=retrigger , we had a ton of retriggers of nightly builds, and unless I'm mistaken, no way of knowing who retriggered them. (There's an owner of toros@m.c, but that matches the owner of the push...)

Dustin: is there a way to map a client ID here?

Severity: normal → enhancement
Flags: needinfo?(dustin)
Priority: -- → P5

Potentially -- it would require changes to the hooks service to make the clientId calling triggerHook available in the JSON-e context, and then using that value in .taskcluster.yml. That might be a good contributor project!

Flags: needinfo?(dustin)

Hm I would work on this

You've got it!

Assignee: nobody → biboswan98

https://docs.taskcluster.net/docs/reference/core/taskcluster-hooks/docs/firing-hooks describes the current JSON-e rendering. The solution I suggest in comment 2 would add a triggeringClientId property to the context for TriggerHook. You can get the value in an API method implementation from await req.clientId().

That's deployed and working fine.

https://tools.taskcluster.net/groups/DKZuEnzcTUy6jecZRdRT8Q/tasks/DKZuEnzcTUy6jecZRdRT8Q/runs/0/logs/public%2Flogs%2Flive.log

[taskcluster 2019-01-17 17:31:06.923Z] === Task Starting ===
hello World from mozilla-auth0/ad|Mozilla-LDAP|dmitchell
[taskcluster 2019-01-17 17:31:07.655Z] === Task Finished ===

Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aee9f213f3c7 include client calling triggerHook in action description r=aki

https://hg.mozilla.org/mozilla-central/rev/aee9f213f3c7

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Backed out changeset aee9f213f3c7 (bug 1496890) for causing Bug 1521264: https://hg.mozilla.org/mozilla-central/rev/a71f2830d57099dc5e83af1cfbcf98c97c68f2f7

this was also requested by Tom Prince on irc and needinfo aki and dustin on this.

Status: RESOLVED → REOPENED
status-firefox66: fixed → ---
Flags: needinfo?(dustin)
Flags: needinfo?(aki)
Resolution: FIXED → ---
Target Milestone: mozilla66 → ---

Ah, that's going to be tricky to solve..

Depends on: 1521264
Flags: needinfo?(dustin)
Flags: needinfo?(aki)

This was fixed in Bug 1521264.

Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: