Closed
Bug 1497144
Opened 6 years ago
Closed 6 years ago
Convert DocShellCapabilities.jsm and ScrollPosition.jsm to C++
Categories
(Firefox :: Session Restore, enhancement, P1)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: alchen, Assigned: alchen)
References
Details
Attachments
(2 files)
Before doing bug 1474130, I would like to rewrite the js modules which are used in ContentSessionStore.jsm.
In this bug, I will focus on DocShellCapabilities.jsm and ScrollPosition.jsm.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → alchen
Assignee | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Comment 1•6 years ago
|
||
Small wishlist item: It would be nice if the resolution saving code used on mobile [1][2] could be integrated into this as well. But since that currently isn't part of ScrollPosition.jsm and Desktop currently doesn't do pinch zooming, either, feel free to ignore my request for now.
[1] https://dxr.mozilla.org/mozilla-central/rev/90853a59691e0c77014c38049bfb38b2b6ca1e16/mobile/android/components/SessionStore.js#938-947
[2] https://dxr.mozilla.org/mozilla-central/rev/90853a59691e0c77014c38049bfb38b2b6ca1e16/mobile/android/chrome/geckoview/GeckoViewContent.js#91-108
Assignee | ||
Comment 3•6 years ago
|
||
Get rid of DocShellCapabilities.jsm and ScrollPosition.jsm
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Try looks fine.
part 1.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b23f33fc72e627f5a376f9e65756b35a57cda2a&selectedJob=207016542
part 2.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bbf7eadfd2307744b366b23247c12ca5962ab53&selectedJob=207008358
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b7afb9ada5e
Rewrite DocShellCapabilities.jsm and ScrollPosition.jsm into C++ r=nika
https://hg.mozilla.org/integration/autoland/rev/50d03049245a
part 2 - Get rid of ScrollPosition.jsm r=JanH,nika
Keywords: checkin-needed
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5b7afb9ada5e
https://hg.mozilla.org/mozilla-central/rev/50d03049245a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•