Closed
Bug 1497187
Opened 6 years ago
Closed 6 years ago
Hide the flexbox container properties in the flex item accordion
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: pbro, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
Screen Shot 2018-10-08 at 15.16.48.png
When displaying the outline and sizing info for a flex item, the flexbox container properties are of very little value. We should hide them there.
|
Reporter | |
Comment 1•6 years ago
|
||
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #9015986 -
Flags: review?(pbrosset)
|
|
Assignee | |
Updated•6 years ago
|
Blocks: dt-flexbox
|
|
Reporter | |
Comment 3•6 years ago
|
||
Comment on attachment 9015986 [details] [diff] [review]
1497187.patch [1.0]
Review of attachment 9015986 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/themes/layout.css
@@ +122,5 @@
> * Flex Item List
> */
>
> +.flex-header + .flex-item-list {
> + border-top: 1px solid var(--theme-splitter-color);
As much as possible, I'd like us to use css logic properties consistently. So here: `border-block-start`
@@ +164,5 @@
> * Flex Item Sizing Outline
> */
>
> .flex-outline-container {
> + border-top: 1px solid var(--theme-splitter-color);
same here
@@ +350,5 @@
> * Flex Container Properties
> */
>
> #flex-container-properties {
> + border-top: 1px solid var(--theme-splitter-color);
and here
Attachment #9015986 -
Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7a4e6283a41
Hide the flexbox container properties in the flex item accordion. r=pbro
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•