Closed
Bug 1497351
Opened 6 years ago
Closed 6 years ago
Do without new null defaults for dictionary-typed members in MediaStreamTrack.webidl
Categories
(Core :: WebRTC: Audio/Video, enhancement, P2)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: jib, Assigned: jib)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1493860 +++
No need to update the spec over this, since we can absorb the absence of members easily enough in the constraints algorithm.
Comment 1•6 years ago
|
||
Well, we need to make sure the spec defines the behavior...
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
The spec's fitness distance algorithm [1] isn't specific enough to need updating, though it does rely on "present" [2], which means, if anything, it should be more correct with this change than before.
In short, a constraint may be given in one of two forms, e.g. for a ConstrainDouble: [3]
(double or ConstrainDoubleRange)
...where one form is a dictionary with only optional members. The absence of said optional members is equivalent to the constraint not being given (the default until bug 1368949), as far as the algorithm goes, by any meaningful interpretation.
[1] https://w3c.github.io/mediacapture-main/getusermedia.html#dfn-fitness-distance
[2] https://heycam.github.io/webidl/#dfn-present
[3] https://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-constraindouble
Comment 4•6 years ago
|
||
> though it does rely on "present"
Perfect. That is exactly what's needed here.
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/336da65f35ea
Remove dictionary null defaults from MediaTrackConstraintSet; handle absence in NormalizedConstraintSet. r=bzbarsky,pehrsons
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•