Closed Bug 1497382 Opened 6 years ago Closed 6 years ago

Symbols dumping can silently fail and lead to incomplete symbols files

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

Bug 1497029 showed that symbol files were truncated. This turns out to happen because for some reason dump_syms fails (haven't dug why yet), but the symbols dumper doesn't care that it failed, so it goes further by shipping the incomplete symbol files. We should prevent this from happening silently.
I can't remember why we never did this. I think we might have had some errors during normal operation that were difficult to work around in the past? Hopefully that's no longer the case, because this does result in hard-to-diagnose errors further down the line.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/8cca84d74504 Make symbolstore.py fail when dump_syms fails r=froydnj
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: