Closed
Bug 1497547
Opened 6 years ago
Closed 4 years ago
Remove VideoAdapter::OnScaleResolutionBy
Categories
(Core :: WebRTC: Audio/Video, enhancement, P3)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: dminor, Assigned: dminor)
References
(Blocks 1 open bug)
Details
We should upstream our OnScaleResolutionBy implementation in VideoAdapter.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Upstream bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=10052
Assignee | ||
Comment 2•6 years ago
|
||
And upstream review: https://webrtc-review.googlesource.com/c/src/+/112140
Assignee | ||
Comment 3•4 years ago
|
||
Upstream doesn't seem interested in this one. They suggested we could use OnOutputFormatRequest instead.
Summary: Upstream VideoAdapter::OnScaleResolutionBy → Remove VideoAdapter::OnScaleResolutionBy
Assignee | ||
Comment 4•4 years ago
|
||
This is surprisingly tricky to get right. But I think we'll have to address this as part of the current libwebrtc update, since the upstream code has changed here.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•