Closed
Bug 1497552
Opened 6 years ago
Closed 6 years ago
Remove support for 44100 Hz in dtmf_tone_generator
Categories
(Core :: WebRTC: Audio/Video, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: dminor, Assigned: dminor)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
If I recall correctly, support for 44100 Hz was added to stop assertions in the unit tests, not for actual calls. We should double check that it is still required (maybe we could change unit tests instead?) and if so, upstream it.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dminor
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
With the assertions here [1] it should not be possible to request a DTMF tone at 44100 Hz here [2] or here [3] which are the only two places that DtmfToneGenerator::Init is called. This code can be safely removed.
[1] https://searchfox.org/mozilla-central/rev/f997bd6bbfc4773e774fdb6cd010142370d186f9/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/neteq_impl.cc#2047
[2] https://searchfox.org/mozilla-central/rev/f997bd6bbfc4773e774fdb6cd010142370d186f9/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/neteq_impl.cc#1823
[3] https://searchfox.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/neteq_impl.cc#1921
Rank: 25
Summary: Upstream support for 44100 Hz in dtmf_tone_generator → Remove support for 44100 Hz in dtmf_tone_generator
|
|
Assignee | |
Comment 2•6 years ago
|
||
Assertions in NetEqImpl::SetSampleRateAndChannels prevent us from requesting
tones at 44100 Hz, so this code can be safely removed.
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ea04ec01e99
Remove support for 44100 Hz in dtmf_tone_generator; r=padenot
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•