Open Bug 1497576 Opened 6 years ago Updated 2 years ago

Rework CamerasParent Singleton

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

Product:
Core
Component:
WebRTC: Audio/Video
Version:
63 Branch
Type:
enhancement

Tracking

()

People

(Reporter: dminor, Unassigned)

References

(Blocks 1 open bug)

Details

From Andreas' review of Bug 1376873:

All the desktop device info stuff seems to be from our patched video capture backend. We really need to undo those patches and put the CamerasParent singleton stuff on top of the pristine capture backends instead.
To clarify, we currently have done a lot of patching to our copy of the webrtc.org video backends. We should undo as much as possible of those.

If there's something patched that we need, like bug fixes, we should upstream them.
If there's something patched to only support our architecture, like the singleton bit, we should work around the patches by adding some wrappers owned by CamerasParent and friends.

The latter point is significant and would let us do future merges with a lot less conflicts.
Flags: needinfo?(jib)

Unsure why I'm being needinfo'ed, but happy to have this on the radar. Our major CamerasParent additions I can think of are the deviceinfo stuff, our process-boundary permission checks, and our downscaling code. I don't know if there are upstream equivalents.

Flags: needinfo?(jib)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.