This is split off bug #1451484. We decided to track landing Desktop and Fenenc sources in separate bugs, so we are able to move forward with the Desktop porting, even if Fennec is blocked by broken tests.

I updated the patch to include a workaround for bug 1495748 suggested by :aswan. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d9bb16c5df9970f1c06e4054be2a6e115107047

I had to toggle the pref in another set of prefs to make the leakcheck fails go away in my machine, which means UA overrides are now disable in 9 tests. Luckily, these are all in `dom/serviceworkers/test/`, so I still feel fine with that. As it is a temporary measure only, fixing the actual cause will happen in bug 1495748. Andrew, is this still fine for you? I've started another try run, that hopefully confirms we no longer fail leackchecks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a5d319ca843a7cab331651582844d2b08c73a1f - It's still running, will check back when it's done. --- As for performance, it looks much better already for some reason: https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=8b00e4aec6606e48b30676d7727c781b0c8ce45c&framework=1&showOnlyImportant=1&selectedTimeRange=172800 All of the regressions are below 5%, so this is probably something we can land and improve later on, if needed. The only percentage spike is a +15% in tp5o responsiveness, but the large relative spike is caused by the super small absolute numbers (0.74 -> 0.86). This reminds me of bug 1457538, and interestingly enough, we also had a 0.7 to 0.8 jump there. So this is probably also something we might be able to land with, and address at a later point.

(In reply to Dennis Schubert [:denschub] from comment #3) > As it is a temporary measure only, fixing the actual cause will > happen in bug 1495748. Andrew, is this still fine for you? Yep! > As for performance, it looks much better already for some reason: > https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla- > central&newProject=try&newRevision=8b00e4aec6606e48b30676d7727c781b0c8ce45c&f > ramework=1&showOnlyImportant=1&selectedTimeRange=172800 > > All of the regressions are below 5%, so this is probably something we can > land and improve later on, if needed. The only percentage spike is a +15% in > tp5o responsiveness, but the large relative spike is caused by the super > small absolute numbers (0.74 -> 0.86). This reminds me of bug 1457538, and > interestingly enough, we also had a 0.7 to 0.8 jump there. So this is > probably also something we might be able to land with, and address at a > later point. Excellent!

Try run looking good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a5d319ca843a7cab331651582844d2b08c73a1f Patch has r+, so I'm requesting checkin. In case there are any performance regressions, bug 1498615 is a related issue, and will probably have the same outcome. :) Thanks again for your help so far, :aswan. Really appreciated.

Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c1aecbca3dd Import WebExtension sources for the WebCompat GoFaster Addon to Desktop. r=aswan

Backed out changeset 7c1aecbca3dd (bug 1498278) for causing leaks at at mozilla::extensions::ChannelWrapper::Get, mozilla::dom::ChannelWrapper_Binding::get, CallJSNative, js::InternalCallOrConstruct Backout: https://hg.mozilla.org/integration/autoland/rev/a0d97137f1d6686476466a57e0fcba6451663a09 Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=205147057&revision=7c1aecbca3ddeb55c60b943a123eb65a052f8594 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205147057&repo=autoland&lineNumber=3574 [task 2018-10-12T19:55:22.262Z] 19:55:22 INFO - GECKO(2449) | SUMMARY: AddressSanitizer: 165081 byte(s) leaked in 946 allocation(s). [task 2018-10-12T19:55:22.451Z] 19:55:22 INFO - TEST-INFO | Main app process: exit 0 [task 2018-10-12T19:55:22.452Z] 19:55:22 INFO - TEST-INFO | LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS [task 2018-10-12T19:55:22.453Z] 19:55:22 INFO - TEST-INFO | LeakSanitizer | This can be done in testing/mozbase/mozrunner/mozrunner/utils.py [task 2018-10-12T19:55:22.454Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::extensions::ChannelWrapper::Get, mozilla::dom::ChannelWrapper_Binding::get, CallJSNative, js::InternalCallOrConstruct [task 2018-10-12T19:55:22.455Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::Node_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.458Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::Document_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.459Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, icu_62::CollationTailoring::ensureOwnedData, icu_62::CollationDataReader::read [task 2018-10-12T19:55:22.460Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, icu_62::CollationDataReader::read, icu_62::CollationRoot::load [task 2018-10-12T19:55:22.461Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::extensions::ChannelWrapper::Get, mozilla::dom::ChannelWrapper_Binding::get, EnterJit, js::jit::MaybeEnterJit [task 2018-10-12T19:55:22.464Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, AllocateObjectBuffer [task 2018-10-12T19:55:22.465Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, icu_62::CollationLoader::makeCacheEntry, makeCacheEntryFromRoot [task 2018-10-12T19:55:22.466Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, mozilla::UniquePtr [task 2018-10-12T19:55:22.466Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, pod_malloc [task 2018-10-12T19:55:22.471Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::EventTarget_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.472Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::IdleDeadline_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.473Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::HTMLMetaElement_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.473Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::PrecompiledScript_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.475Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, copyOnWrite, icu_62::RuleBasedCollator::setAttribute [task 2018-10-12T19:55:22.476Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_realloc, maybe_pod_realloc, js::Nursery::reallocateBuffer, ReallocateObjectBuffer [task 2018-10-12T19:55:22.476Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::MatchGlob_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.478Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::HTMLAnchorElement_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.478Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::ChannelWrapper_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.479Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingRealloc, ICUReporter::Realloc, icu_62::UnicodeSet::ensureCapacity, icu_62::UnicodeSet::add [task 2018-10-12T19:55:22.480Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::ChromeMessageBroadcaster_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.481Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::WebExtensionPolicy_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.481Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::URL_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.482Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, icu_62::CollationTailoring::CollationTailoring, icu_62::CollationRoot::load [task 2018-10-12T19:55:22.483Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::ProgressEvent_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.483Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_new, MakeUnique, HashChildren, js::PropertyTree::insertChild [task 2018-10-12T19:55:22.484Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, utrie2_openFromSerialized_62, icu_62::CollationDataReader::read [task 2018-10-12T19:55:22.485Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::TextDecoder_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.486Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, js::Shape::hashify [task 2018-10-12T19:55:22.486Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::console_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.487Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, createTable [task 2018-10-12T19:55:22.488Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, js::RegExpStatics::create [task 2018-10-12T19:55:22.488Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::Request_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.489Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::PlacesObservers_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.490Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::HTMLHtmlElement_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.490Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::DOMParser_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.491Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::Headers_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.492Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::MessageListenerManager_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.493Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, js::TenuringTracer::moveSlotsToTenured [task 2018-10-12T19:55:22.493Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, UDataMemory_createNewInstance_62, checkDataItem [task 2018-10-12T19:55:22.494Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::StructuredCloneHolder_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.495Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::Worker_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.495Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_calloc, maybe_pod_calloc, js::ShapeTable::init, js::Shape::hashify [task 2018-10-12T19:55:22.496Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::XMLDocument_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.497Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, CopyScopeData [task 2018-10-12T19:55:22.497Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, allocateStrings, icu_62::UnicodeSet::UnicodeSet [task 2018-10-12T19:55:22.498Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, _init, icu_62::UVector::UVector [task 2018-10-12T19:55:22.499Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::PlacesWeakCallbackWrapper_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.499Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, icu_62::UnicodeSet::freeze, icu_62::CollationDataReader::read [task 2018-10-12T19:55:22.500Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at WeakPtr, SupportsWeakPtr, mozilla::extensions::ChannelWrapper::ChannelWrapper, mozilla::extensions::ChannelWrapper::Get [task 2018-10-12T19:55:22.501Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::Attr_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.501Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, icu_62::CollationRoot::load, umtx_initOnce [task 2018-10-12T19:55:22.502Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, tryNewTenuredObject [task 2018-10-12T19:55:22.503Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::ParentProcessMessageManager_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.504Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::HTMLCollection_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.505Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::MozQueryInterface_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle [task 2018-10-12T19:55:22.507Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at js_pod_arena_calloc, maybe_pod_calloc, pod_calloc, AllocScriptData [task 2018-10-12T19:55:22.508Z] 19:55:22 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at CountingMalloc, ICUReporter::Alloc, makeInstance, icu_62::Collator::createInstance [task 2018-10-12T19:55:22.508Z] 19:55:22 INFO - runtests.py | Application ran for: 0:02:44.447682 [task 2018-10-12T19:55:22.510Z] 19:55:22 INFO - zombiecheck | Reading PID log: /tmp/tmpRV3QDKpidlog

Welp. As far as the build looks ([0]) the Linux asan build is the only failing build. Not super surprising as it is the asan build, but... mh. Unfortunately, it's really late here and I am out of ideas... :aswan, mind taking another look? (Sorry.) [0]: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=205147057&revision=7c1aecbca3ddeb55c60b943a123eb65a052f8594

Here's a try push of the new GoFaster version, without the modified tests, and with the patch from bug 1495748: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dc352c4bca2d1e7cb61d06cd3af904a57227a49

Try run with the revised bug 1495748 patch looks great so far: https://treeherder.mozilla.org/#/jobs?repo=try&revision=925c522c7a9bb2ce1b3de6e6fab36fb83fc14ec0 Hopefully we can get that one landed soon to clear the way for this one.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a4d5c538be50c9b5c7cd2f1a4003508791d733 Bug 1498278 - Import WebExtension sources for the WebCompat GoFaster Addon to Desktop. r=aswan

It looks like this regressed JS memory usage by 11KB on the AWSY base test case. Kris, do you think there's anything we can do to mitigate that?