These tests trigger the dnd suppression by trying to move window around at wrong time and such, and to get rid of the suppression, one needs a mouseup. (the suppression is for a security issue) The patch is needed to be able to land bug 1498381.

Comment on attachment 9016594 [details] [diff] [review] artificial_mouseup.diff Review of attachment 9016594 [details] [diff] [review]: ----------------------------------------------------------------- Can you elaborate on "trying to move the window around" ? Neither of these tests try to move any browser windows. They do other dnd operations. Why are those getting misinterpreted as window moves?

It can be also resizing https://searchfox.org/mozilla-central/rev/1ce4e8a5601da8e744ca6eda69e782318afab54d/dom/base/nsGlobalWindowOuter.cpp#4502,4549

And then this stuff relies on https://searchfox.org/mozilla-central/rev/1ce4e8a5601da8e744ca6eda69e782318afab54d/dom/base/nsGlobalWindowInner.cpp#1975,1977,1983

FWIW, we may need to tweak the dnd suppression, since it was added way before e10s, but I'm just keeping the existing behavior of these tests.

Comment on attachment 9016594 [details] [diff] [review] artificial_mouseup.diff I guess I can fix this also in EventUtils.js, where the bug, one could argue, is.

ok, I'll fix this in bug 1498381.

Or no, I don't want to expand the scope of bug 1089326 even more.

Just with more accurate comment. We clearly need some fixes to testing framework, but that isn't exactly trivial and this patch just keeps the existing behavior.

Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0178681fab81 browser_homeDrop.js and customizableui/test/head.js rely on EventUtils.js to dispatch artificial mouseup after dnd, r=gijs

Backout by rgurzau@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/4b02380c0bbb Backed out 2 changesets (bug 1498379, bug 1498381) for permafailing at /test/tabs/browser_multiselect_tabs_drag_to_bookmarks_toolbar.js a=backout

Backed out 2 changesets (bug 1498379, bug 1498381) for permafailing at /test/tabs/browser_multiselect_tabs_drag_to_bookmarks_toolbar.js a=backout Backout link: https://hg.mozilla.org/mozilla-central/rev/4b02380c0bbb5151f1a1f4606c29f2a1cbb70225 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending,running,success,testfailed,busted,exception&revision=03f328ed7618d4fcdaad1688f4f2012f11f55084&selectedJob=205254870 Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=205254870&repo=mozilla-inbound&lineNumber=5838 Log snippet: 11:27:33 INFO - Console message: [JavaScript Error: "Empty array passed for required input property: 11:27:33 INFO - guids" {file: "resource://gre/modules/PlacesTransactions.jsm" line: 826}] 11:27:33 INFO - validateInput@resource://gre/modules/PlacesTransactions.jsm:826:17 11:27:33 INFO - DefineTransaction.validatePropertyValue@resource://gre/modules/PlacesTransactions.jsm:847:36 11:27:33 INFO - DefineTransaction.verifyInput@resource://gre/modules/PlacesTransactions.jsm:891:24 11:27:33 INFO - ctor@resource://gre/modules/PlacesTransactions.jsm:693:15 11:27:33 INFO - ctor@resource://gre/modules/PlacesTransactions.jsm:689:14 11:27:33 INFO - getTransactionsForTransferItems@resource:///modules/PlacesUIUtils.jsm:1181:13 11:27:33 INFO - handleTransferItems@resource:///modules/PlacesUIUtils.jsm:934:22 11:27:33 INFO - async*onDrop@chrome://browser/content/places/controller.js:1441:11 11:27:33 INFO - async*PT__onDrop@chrome://browser/content/places/browserPlacesViews.js:1824:7 11:27:33 INFO - PT_handleEvent@chrome://browser/content/places/browserPlacesViews.js:1225:9 11:27:33 INFO - sendDragEvent@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:263:10 11:27:33 INFO - synthesizePlainDragAndDrop@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:2462:5 11:27:33 INFO - async*test@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_multiselect_tabs_drag_to_bookmarks_toolbar.js:42:9 11:27:33 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1093:34 11:27:33 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1084:16 11:27:33 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:986:9 11:27:33 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59 11:27:33 INFO - 11:27:33 INFO - Buffered messages finished 11:27:33 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_drag_to_bookmarks_toolbar.js | Uncaught exception - waiting for 2 bookmarks - timed out after 50 tries. 11:27:33 INFO - Leaving test bound test 11:27:33 INFO - GECKO(1180) | --DOMWINDOW == 11 (085DC800) [pid = 3888] [serial = 37] [outer = 00000000] [url = about:blank] 11:27:33 INFO - GECKO(1180) | --DOMWINDOW == 10 (0BFF3800) [pid = 3888] [serial = 32] [outer = 00000000] [url = about:blank] 11:27:33 INFO - GECKO(1180) | --DOMWINDOW == 9 (0BF1DC00) [pid = 3888] [serial = 35] [outer = 00000000] [url = http://mochi.test:8888/] 11:27:33 INFO - GECKO(1180) | --DOMWINDOW == 8 (0BF1F000) [pid = 3888] [serial = 38] [outer = 00000000] [url = http://mochi.test:8888/] 11:27:33 INFO - GECKO(1180) | MEMORY STAT | vsize 787MB | vsizeMaxContiguous 613MB | residentFast 247MB | heapAllocated 89MB

uh, windows

with bustage fix

Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/39df6098355c browser_homeDrop.js and head.js rely on EventUtils.js to dispatch artificial mouseup after dnd, r=gijs