Closed
Bug 1498410
Opened 6 years ago
Closed 6 years ago
Export Screenshots 35.0.0
Categories
(Firefox :: Screenshots, enhancement)
Firefox
Screenshots
Tracking
()
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
Attachments
(6 files, 1 obsolete file)
Export changes since the 33.0.0 addon release (bug 1465581).
Main change here is migrating from a bootstrapped, legacy extension to a pure webextension with chrome bits contained in an embedded API experiment.
Changelog will be added in a comment.
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: IqghO4R1RAZ
Bug 1498410 - Part 2 - Export Screenshots 35.0.0 (upgrade Raven to 3.27.0); r?ianbicking
MozReview-Commit-ID: 711GJNJtNYn
Bug 1498410 - Part 3 - Export Screenshots 35.0.0 (code excluding translations and Raven upgrade); r?aswan,ianbicking
MozReview-Commit-ID: IF010Y5ERks
Bug 1498410 - Part 4 - Export comma-dangle refactoring as a separate commit to ease reviews; r?ianbicking
MozReview-Commit-ID: 455LZbfCGfy
Bug 1498410 - Part 5 - Fix tests broken by Screenshots migration to pure webextension; r?aswan
* Explicitly disable Screenshots in PageActions and context menu tests
* Update browser_preferences_usage test to accommodate Screenshots as a webextension
(Moving Screenshots from legacy bootstrap to webextension seems to require reducing
the minimum number of values in the `extensions.getAddons.cache.enabled` pref by one)
MozReview-Commit-ID: LCNaaXSE8w0
Assignee | ||
Comment 2•6 years ago
|
||
MozReview-Commit-ID: IqghO4R1RAZ
Assignee | ||
Comment 3•6 years ago
|
||
MozReview-Commit-ID: 711GJNJtNYn
Assignee | ||
Comment 4•6 years ago
|
||
MozReview-Commit-ID: IF010Y5ERks
Assignee | ||
Comment 5•6 years ago
|
||
MozReview-Commit-ID: 455LZbfCGfy
Assignee | ||
Comment 6•6 years ago
|
||
* Explicitly disable Screenshots in PageActions and context menu tests
* Update browser_preferences_usage test to accommodate Screenshots as a webextension
(Moving Screenshots from legacy bootstrap to webextension seems to require reducing
the minimum number of values in the `extensions.getAddons.cache.enabled` pref by one)
MozReview-Commit-ID: LCNaaXSE8w0
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 9016539 [details]
Bug 1498410 - Part 1 - Export Screenshots 35.0.0 (translations only); r?ianbicking,flod
Bad review request, didn't realize arc diff needed to be called separately for each commit in a series :-(
Attachment #9016539 -
Attachment is obsolete: true
Assignee | ||
Comment 8•6 years ago
|
||
Am I doing this right? Separate 'arc diff' incantation for each commit in a series?
Flags: needinfo?(aswan)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jhirsch
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•6 years ago
|
||
Try run with final, reviewed commits, and with artifact builds disabled (to ensure Talos results are reliable):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b65410b8c0d6ec0f9707620d2de2f8b5185be880
Comment 11•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a7fd350ec1d
Part 1 - Export Screenshots 35.0.0 (translations only); r=flod,ianbicking
Comment 12•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40f06570e491
Part 2 - Export Screenshots 35.0.0 (upgrade Raven to 3.27.0); r=ianbicking
Comment 13•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db5f7c857952
Part 3 - Export Screenshots 35.0.0 (code excluding translations and Raven upgrade); r=aswan,ianbicking
Comment 14•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ba024979004
Part 4 - Export comma-dangle refactoring as a separate commit to ease reviews; r=ianbicking
Comment 15•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4842c9240ccf
Part 5 - Fix tests broken by Screenshots migration to pure webextension; r=aswan
Comment 16•6 years ago
|
||
Backed out 5 changesets (Bug 1498410) for browser-chrome failures at browser/base/content/test/performance/browser_preferences_usage.js
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=205231601&revision=0a7fd350ec1d9faebe324a8e2e5dc9008c281dae
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205229656&repo=autoland&lineNumber=1923
Backout link: https://hg.mozilla.org/integration/autoland/rev/f17dfd86498ec12d828373d6b7b2d76f29983d22
02:47:38 INFO - TEST-START | browser/base/content/test/performance/browser_preferences_usage.js
02:47:38 INFO - GECKO(4808) | ++DOMWINDOW == 7 (000001DC84DA8400) [pid = 940] [serial = 7] [outer = 000001DC84ADE400]
02:47:38 INFO - TEST-INFO | started process screenshot
02:47:38 INFO - TEST-INFO | screenshot: exit 0
02:47:38 INFO - Buffered messages logged at 02:47:38
02:47:38 INFO - Entering test bound debug_only
02:47:38 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | You need to run this test on a debug build. -
02:47:38 INFO - Leaving test bound debug_only
02:47:38 INFO - Entering test bound startup
02:47:38 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | startupRecorder has prefStats -
02:47:38 INFO - network.loadinfo.skip_type_assertion should not be accessed more than 40 times and was accessed 754 times.
02:47:38 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item browser.startup.record should be accessed at least 200 times. - 200 <= 284 -
02:47:38 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item browser.startup.record should be accessed at most 350 times. - 284 <= 350 -
02:47:38 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item layout.css.prefixes.webkit should be accessed at least 135 times. - 135 <= 168 -
02:47:38 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item layout.css.prefixes.webkit should be accessed at most 170 times. - 168 <= 170 -
02:47:38 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | Whitelist item layout.css.dpi should be accessed at least 45 times. - 45 <= 76 -
02:47:38 INFO - Buffered messages finished
02:47:38 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/perform
Updated•6 years ago
|
Flags: needinfo?(jhirsch)
Assignee | ||
Comment 17•6 years ago
|
||
Looks like one of the tests changed just as my patch was landing
Flags: needinfo?(jhirsch)
Assignee | ||
Comment 18•6 years ago
|
||
MozReview-Commit-ID: Bdwv9rFBwm3
Comment 19•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb1c936feb43
Part 1 - Export Screenshots 35.0.0 (translations only); r=flod,ianbicking
Comment 20•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/909a38c04700
Part 2 - Export Screenshots 35.0.0 (upgrade Raven to 3.27.0); r=ianbicking
Comment 21•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/426257ad4b83
Part 3 - Export Screenshots 35.0.0 (code excluding translations and Raven upgrade); r=aswan,ianbicking
Comment 22•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01fa6937f05f
Part 4 - Export comma-dangle refactoring as a separate commit to ease reviews; r=ianbicking
Comment 23•6 years ago
|
||
Pushed by jhirsch@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bf7bb3f9e58
Part 6 - Update browser_preferences_usage test for non-bootstrapped Screenshots;r=aswan
Comment 24•6 years ago
|
||
Backed out 5 changesets (bug 1498410) for faulty landing
missing part 5
https://hg.mozilla.org/integration/autoland/rev/b2cd2ffe4ec85aad87f3445cd1e6badad0a45010
Assignee | ||
Comment 25•6 years ago
|
||
Lando didn't detect a merge conflict with part 5. Working with :Aryx to resolve the problem
Comment 26•6 years ago
|
||
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/2c8dd9e9532a
Part 1 - Export Screenshots 35.0.0 (translations only); r=flod,ianbicking
https://hg.mozilla.org/integration/autoland/rev/f3f88bdd7e38
Part 2 - Export Screenshots 35.0.0 (upgrade Raven to 3.27.0); r=ianbicking
https://hg.mozilla.org/integration/autoland/rev/3fab2169b6a0
Part 3 - Export Screenshots 35.0.0 (code excluding translations and Raven upgrade); r=aswan,ianbicking
https://hg.mozilla.org/integration/autoland/rev/9ea94e903beb
Part 4 - Export comma-dangle refactoring as a separate commit to ease reviews; r=ianbicking
https://hg.mozilla.org/integration/autoland/rev/62bc409457f3
Part 5 - Fix tests broken by Screenshots migration to pure webextension; r=aswan
https://hg.mozilla.org/integration/autoland/rev/ed1c9d5965db
Part 6 - Update browser_preferences_usage test for non-bootstrapped Screenshots;r=aswan
Comment 27•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2c8dd9e9532a
https://hg.mozilla.org/mozilla-central/rev/f3f88bdd7e38
https://hg.mozilla.org/mozilla-central/rev/3fab2169b6a0
https://hg.mozilla.org/mozilla-central/rev/9ea94e903beb
https://hg.mozilla.org/mozilla-central/rev/62bc409457f3
https://hg.mozilla.org/mozilla-central/rev/ed1c9d5965db
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•