Remove new Function from wizard.xml
Categories
(Core :: DOM: Security, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: vinoth, Assigned: jallmann)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: [domsecurity-backlog1])
Attachments
(2 files)
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
|
Reporter | |
Comment 1•6 years ago
|
||
|
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Updated•6 years ago
|
|
Assignee | |
Comment 2•6 years ago
|
||
I have a question that also applies to Bug 1498566.
After replacing all onwizard*-attributes in the codebase by proper event handlers, can I just remove this block of code
https://searchfox.org/mozilla-central/source/toolkit/content/widgets/wizard.xml#419
entirely without replacement? And if yes, am I right that this documentation
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/wizard
would have to be adapted, because the attributes wont work anymore?
|
||
Comment 3•6 years ago
|
||
(In reply to Jonas Allmann [:jallmann] from comment #2)
I have a question that also applies to Bug 1498566.
After replacing all onwizard*-attributes in the codebase by proper event handlers, can I just remove this block of codehttps://searchfox.org/mozilla-central/source/toolkit/content/widgets/wizard.xml#419
entirely without replacement? And if yes, am I right that this documentation
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/wizard
would have to be adapted, because the attributes wont work anymore?
Yes for both of these. :-)
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 4•6 years ago
|
||
- Removed all occurences of custom onwizard* attributes.
- Removed custom handler code from wizard.xml.
- Updated eval()-usage whitelist.
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 5•6 years ago
|
||
Dev-docs need to be updated as a consequence of this Bug.
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/wizard
The attributes onextra1, onextra2, onwizardback, onwizardcancel, onwizardfinish, onwizardnext for the XUL-Element wizard are no longer supported. Using custom event handlers in the script code is recommended instead.
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/wizardpage
The attributes onpageadvanced, onpagehide, onpagerewound, onpageshow for the wizardpage Element are no longer supported either.
|
|
Assignee | |
Comment 6•6 years ago
|
||
This Bug is ready to land, could you do that for me, ckerschb?
|
|
||
Comment 7•6 years ago
|
||
I've triggered lando for you. In future, you can also set the 'checkin-needed' keyword on the bug.
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Description
•