Closed
Bug 1498586
Opened 6 years ago
Closed 6 years ago
clang-format: Ignore some formatting
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox-esr60 fixed, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
patch
|
lizzard
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Too hard/impossible for the tool to format correctly these structs
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7807742373e1
Add clang-format off to avoid the reformatting of the data structures r=Ehsan
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sledru
| Comment hidden (typo) |
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9030737 [details] [diff] [review]
ESR patch
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.
User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.
Fix Landed on Version: 64
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Comment additions only, should not change anything in the binary. Has also been tested in Nightly for a couple of months or so...
String or UUID changes made by this patch: None
Attachment #9030737 -
Flags: approval-mozilla-release? → approval-mozilla-esr60?
|
|
||
Comment 6•6 years ago
|
||
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Please see comment 5
User impact if declined:
Fix Landed on Version:
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky):
String or UUID changes made by this patch:
Attachment #9030737 -
Attachment is obsolete: true
Attachment #9030737 -
Flags: approval-mozilla-esr60?
Attachment #9030980 -
Flags: approval-mozilla-esr60?
status-firefox-esr60:
--- → affected
Comment on attachment 9030980 [details] [diff] [review]
ESR patch
OK for uplift to ESR60 as part of the clang-format project.
Attachment #9030980 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
|
|
||
Comment 8•6 years ago
|
||
| bugherder uplift | ||
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•