Closed
Bug 1498618
Opened 6 years ago
Closed 6 years ago
Never apply clang-format on code in {{{ check_macroassembler_style
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox-esr60 fixed, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
patch
|
lizzard
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
Because the python is expecting a very specific programming patterns and it isn't easy to update it.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
The python script works with any changes in js/src/.clang-format
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7127bf67c3b9
Never apply clang-format on code in {{{ check_macroassembler_style r=nbp
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Comment 5•6 years ago
|
||
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.
User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.
Fix Landed on Version: 64
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Comment additions only, should not change anything in the binary. Has also been tested in Nightly for a couple of months or so...
String or UUID changes made by this patch: None
Attachment #9030738 -
Flags: approval-mozilla-esr60?
|
|
||
Updated•6 years ago
|
Attachment #9030738 -
Attachment is patch: true
Attachment #9030738 -
Attachment mime type: application/octet-stream → text/plain
status-firefox-esr60:
--- → affected
Comment on attachment 9030738 [details] [diff] [review]
ESR patch
OK for uplift to ESR60 as part of the clang-format project.
Attachment #9030738 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
|
|
||
Comment 7•6 years ago
|
||
| bugherder uplift | ||
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•