Geoff Brown [:gbrown] Assignee
	Description • 6 years ago

With recent changes we can run wpt on android. However instead of restarting the browser between groups of tests, I see a 60 second pause. What are we waiting for?

Running locally:

$ ./mach -v wpt testing/web-platform/tests/infrastructure/
...
 0:33.28 TEST_START: /infrastructure/assumptions/cookie.html
 0:33.38 TEST_END: Test OK. Subtests passed 1/1. Unexpected 0
 0:33.39 TEST_START: /infrastructure/assumptions/html-elements.html
 0:33.62 TEST_END: Test OK. Subtests passed 11/11. Unexpected 0
 0:33.62 TEST_START: /infrastructure/assumptions/non-secure-context.any.worker.html
 0:33.78 TEST_END: Test OK. Subtests passed 2/2. Unexpected 0
 0:33.78 TEST_START: /infrastructure/assumptions/non-secure-context.any.html
 0:33.93 TEST_END: Test OK. Subtests passed 2/2. Unexpected 0
 0:33.93 INFO Restarting browser for new test environment
 1:35.95 WARNING u'runner_teardown': ()
 1:35.95 INFO Closing logging queue
 1:35.95 INFO queue closed

Notice the 60+ second wait after "Restarting browser for new test environment".

	Geoff Brown [:gbrown] Assignee
	Comment 1 • 6 years ago

This works great for me so far, but I'm still testing.

	Geoff Brown [:gbrown] Assignee
	Comment 2 • 6 years ago

Now:

 0:29.33 TEST_END: Test OK. Subtests passed 2/2. Unexpected 0
 0:29.33 INFO Restarting browser for new test environment
 0:30.38 INFO Browser exited with return code 0
 0:30.38 WARNING u'runner_teardown': ()
 0:30.38 INFO Closing logging queue
 0:30.38 INFO queue closed

	Geoff Brown [:gbrown] Assignee
	Comment 3 • 6 years ago

Comment on attachment 9016767 [details] [diff] [review]
request browser stop before waiting

Seems to do no harm:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=ec09f47d93734eba17a0fa51599843fe02ce6aab

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 4 • 6 years ago

Comment on attachment 9016767 [details] [diff] [review]
request browser stop before waiting

Haven't tested it yet myself, but this looks right to me.

	Pulsebot
	Comment 5 • 6 years ago

Pushed by wkocher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/54598c1940f1
Fix wpt runner's browser stop implementation: request stop before waiting; r=kwierso

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 6 • 6 years ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13501 for changes under testing/web-platform/tests

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 7 • 6 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

	Arthur Iakab [arthur_iakab]
	Comment 8 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/54598c1940f1

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 9 • 6 years ago

Upstream PR merged

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 10 • 6 years ago

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13501
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/RL7NC741SiSYdYxjhC0Ltw)